[CALCITE-3167] Remove overriding equals and hashCode methods in EnumerableTableScan

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.21.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Julian Hyde
• Reporter: Jin Xing
• Created: 02/Jul/19 10:02
• Updated: 26/Oct/19 04:21
• Resolved: 21/Aug/19 02:04

Description

In current code of EnumerableTableScan, methods of equals and hashCode are overridden for matching of {{EnumerableTableScan}}s.

While after optimizing with the same HEP planner, {{EnumerableTableScan}}s from two plans but with the same digest will the share the same Java object. See RelOptMaterializations.

I think it's ok to remove the redundant overriding methods in EnumerableTableScan.

Issue Links

• is related to: CALCITE-3447 Fix equivalents in method SubstitutionVisitor#go
• is related to: CALCITE-1216 Add new rules for Materialised view optimisation of join queries
• links to: GitHub Pull Request #1294