Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3167

Remove overriding equals and hashCode methods in EnumerableTableScan

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.19.0
    • Fix Version/s: 1.21.0
    • Component/s: core

      Description

      In current code of EnumerableTableScan, methods of equals and hashCode are overridden for matching of {{EnumerableTableScan}}s.

      While after optimizing with the same HEP planner, {{EnumerableTableScan}}s from two plans but with the same digest will the share the same Java object. See RelOptMaterializations.

      I think it's ok to remove the redundant overriding methods in EnumerableTableScan.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                jinxing6042@126.com Jin Xing
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m