[CALCITE-3136] Fix the default rule description of ConverterRule.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.21.0
• Component/s: core
• Labels: pull-request-available
• Assignee: TANG Wen-hui
• Reporter: TANG Wen-hui
• Created: 19/Jun/19 13:26
• Updated: 27/Sep/19 07:12
• Resolved: 22/Jul/19 01:40

Description

The default rule description of ConvertRule does not obey the description pattern of RelOptRule.

public RelOptRule(RelOptRuleOperand operand,
    RelBuilderFactory relBuilderFactory, String description) {
  this.operand = Objects.requireNonNull(operand);
  this.relBuilderFactory = Objects.requireNonNull(relBuilderFactory);
  if (description == null) {
    description = guessDescription(getClass().getName());
  }
  if (!description.matches("[A-Za-z][-A-Za-z0-9_.():]*")) {
    throw new RuntimeException("Rule description '" + description
        + "' is not valid");
  }
  this.description = description;
  this.operands = flattenOperands(operand);
  assignSolveOrder();
}

public <R extends RelNode> ConverterRule(Class<R> clazz,
    Predicate<? super R> predicate, RelTrait in, RelTrait out,
    RelBuilderFactory relBuilderFactory, String description) {
  super(convertOperand(clazz, predicate, in),
      relBuilderFactory,
      description == null
          ? "ConverterRule<in=" + in + ",out=" + out + ">"
          : description);
  this.inTrait = Objects.requireNonNull(in);
  this.outTrait = Objects.requireNonNull(out);

  // Source and target traits must have same type
  assert in.getTraitDef() == out.getTraitDef();
}

Issue Links

• supercedes: CALCITE-3099 The description of SplunkPushDownRule doesn't match expression check in RelOptRule
• links to: GitHub Pull Request #1275