[CALCITE-3099] The description of SplunkPushDownRule doesn't match expression check in RelOptRule

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.22.0
• Component/s: splunk
• Labels: pull-request-available
• Assignee: Shawn Chen
• Reporter: Shawn Chen
• Created: 29/May/19 03:50
• Updated: 06/Mar/20 04:36
• Resolved: 27/Sep/19 07:12

Description

Some SplunkPushDownRule instance has a description that contains spaces, for example:

The description of PROJECT_ON_FILTER is "proj on filter on proj", which doesn't match the expression check in RelOptRule:

if (!description.matches("[A-Za-z][-A-Za-z0-9_.():]*")) {
      throw new RuntimeException("Rule description '" + description
          + "' is not valid");
    }

The constructor of SplunkPushDownRule also contains spaces when invoking super():

  /** Creates a SplunkPushDownRule. */
  protected SplunkPushDownRule(RelOptRuleOperand rule,
      RelBuilderFactory relBuilderFactory, String id) {
    super(rule, relBuilderFactory, "SplunkPushDownRule: " + id);
  }

Issue Links

• is superceded by: CALCITE-3136 Fix the default rule description of ConverterRule.
• links to: GitHub Pull Request #1251