Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-306

Standardize code style for "import package.*;"

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 1.0.0-incubating
    • None
    • None

    Description

      Our house style does not specify whether/when imports are to be converted to stars. I propose that imports should be converted to stars if there are more than 3 from the same package. Thus:

      import a.b.C1;
      import a.b.C2;
      import a.b.C3;
      

      becomes

      import a.b.*;
      

      when a.b.C4 is added. This is consistent with IntelliJ's default rule.

      It is OK to use stars if there are 3 or fewer uses. Thus removing the use of a.b.C2 would not require imports to be changed.

      Checkstyle has a rule to ban star imports (excluding certain packages) but does not allow them to be limited to a particular number.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            julianhyde Julian Hyde
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment