[CALCITE-3041] Query runs endless when setImportance to 0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Fix Version/s: 1.23.0
• Component/s: core
• Assignee: Danny Chen
• Reporter: Haisheng Yuan
• Created: 30/Apr/19 21:09
• Updated: 28/May/21 10:11
• Resolved: 10/Mar/20 00:12

Description

Make the following changes:

--- a/core/src/main/java/org/apache/calcite/rel/rules/AggregateRemoveRule.java
+++ b/core/src/main/java/org/apache/calcite/rel/rules/AggregateRemoveRule.java
@@ -123,6 +123,7 @@ public void onMatch(RelOptRuleCall call) {
       // aggregate functions, add a project for the same effect.
       relBuilder.project(relBuilder.fields(aggregate.getGroupSet().asList()));
     }
+    call.getPlanner().setImportance(aggregate, 0.0);
     call.transformTo(relBuilder.build());
   }
 }

The query in JdbcTest.testGroupBy1Max1 will run endless.

Issue Links

• Blocked: CALCITE-2223 ProjectMergeRule is infinitely matched when is applied after ProjectReduceExpressionsRule
• Blocked: CALCITE-2589 VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse should ignore known-to-be-unimportant relations
• is related to: CALCITE-3505 Infinite matching of FilterProjectTransposeRule causes stackoverflow