[CALCITE-2589] VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse should ignore known-to-be-unimportant relations

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Vladimir Sitnikov
• Created: 23/Sep/18 08:46
• Updated: 20/Feb/20 05:39

Description

call.getPlanner().setImportance is used to avoid use of known-to-be-inefficient relation, however the check of importance is performed very late.

The check is performed in org.apache.calcite.plan.volcano.RuleQueue#skipMatch when ruleCalls have already been created.

I suggest to move the check into VolcanoPlanner#fireRules and VolcanoRuleCall#matchRecurse

It would reduce amount of "possible" rule executions.

Note: calling setImportance BEFORE transformTo would would help as well to filter out unimportant rule calls early.

Issue Links

• Blocked: CALCITE-3041 Query runs endless when setImportance to 0
• blocks: CALCITE-2575 Release Calcite 1.18.0
• links to: PR 855