Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2435

Refactor SqlTestFactory

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.17.0
    • 1.18.0
    • core
    • None

    Description

      Current SqlTestFactory/DelegatingSqlTestFactory is hard to reason about, and it is hard to extend/cache properly.

      There are three key changes here:

      1. Rename DefaultSqlTestFactory to SqlTestFactory. SqlTestFactory was an interface, however it has a single viable implementation, so it makes little sense to keep it as is.
      2. Move MockCatalogReader.init and MockCatalogReader.init2 to MockCatalogReaderSimple and MockCatalogReaderExtended
      3. Move MockCatalogReader to its own package, and split several inner classes to a top-level ones.
      4. Replace usages

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-2433 SqlAdvisor.getCompletionHints is hard-coded for " quoting

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-2484 Dynamic table tests give wrong results when running tests concurrently.

          • Major - Major loss of function.
          • Closed
          links to

          Web Link Fixed in 96b28f7ba11de22a68d984de6b6b88311cc2c57e

          Web Link PR 771

          Activity

            People

              julianhyde Julian Hyde
              vladimirsitnikov Vladimir Sitnikov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: