[CALCITE-2433] SqlAdvisor.getCompletionHints is hard-coded for " quoting

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 31/Jul/18 18:12
• Updated: 23/Dec/18 00:12
• Resolved: 05/Sep/18 14:23

Description

Relevant source:

    boolean quoted = false;
    while (wordStart > 0
        && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
      --wordStart;
    }
    if ((wordStart > 0)
        && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting from the connection
      quoted = true;
      --wordStart;
    }

Issue Links

• duplicates: CALCITE-152 SqlAdvisor should honor quoting rules
• is blocked by: CALCITE-2435 Refactor SqlTestFactory