Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1889

SqlValidatorUtil#checkIdentifierListForDuplicates should accept compound identifiers as well

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently SqlValidatorUtil#checkIdentifierListForDuplicates working for single identifiers only but it can accept compound identifiers also as arguments.

        Issue Links

          Activity

          Hide
          michaelmior Michael Mior added a comment -

          Resolved in release 1.14.0 (2017-10-01)

          Show
          michaelmior Michael Mior added a comment - Resolved in release 1.14.0 (2017-10-01)
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/93a96ddf ; thanks for the PR, Rajeshbabu Chintaguntla !
          Hide
          julianhyde Julian Hyde added a comment -

          Reviewing now.

          Show
          julianhyde Julian Hyde added a comment - Reviewing now.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          Julian Hyde As for your review comments here https://issues.apache.org/jira/browse/CALCITE-1709?focusedCommentId=16077149&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16077149
          I have ran dynamic columns tests with changes done in PR linked here and all the tests are passing and also handled reviews comments and updated PR. Please review.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - Julian Hyde As for your review comments here https://issues.apache.org/jira/browse/CALCITE-1709?focusedCommentId=16077149&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16077149 I have ran dynamic columns tests with changes done in PR linked here and all the tests are passing and also handled reviews comments and updated PR. Please review.

            People

            • Assignee:
              rajeshbabu Rajeshbabu Chintaguntla
              Reporter:
              rajeshbabu Rajeshbabu Chintaguntla
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development