[CALCITE-1709] Support mixing table columns with extended columns in DML

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.14.0
• Assignee: Rajeshbabu Chintaguntla
• Reporter: Kevin Liew
• Created: 19/Mar/17 03:00
• Updated: 02/Oct/17 14:31
• Resolved: 27/Jun/17 22:34

Description

Phoenix allows embedding dynamic column definitions in the UPDATE target column list whereas Calcite requires that extended columns be specified separately from the target columns.

ie.
Phoenix

UPSERT INTO EventLog
(eventId, eventTime, eventType, lastGCTime TIME, usedMemory BIGINT, maxMemory BIGINT)
VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);

Calcite

UPSERT INTO EventLog
(lastGCTime TIME, usedMemory BIGINT, maxMemory BIGINT)
(eventId, eventTime, eventType, lastGCTime, usedMemory, maxMemory)
VALUES (1, CURRENT_TIME(), ‘abc’, CURRENT_TIME(), 512, 1024);

We should have a conformance setting for this feature. https://issues.apache.org/jira/browse/PHOENIX-3732?focusedCommentId=15930704&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15930704

Issue Links

• depends upon: CALCITE-1702 Support extended columns in DML
• is depended upon by: PHOENIX-3732 Support for dynamic columns in UPSERT in Phoenix-Calcite
• is depended upon by: CALCITE-1889 SqlValidatorUtil#checkIdentifierListForDuplicates should accept compound identifiers as well
• links to: PR 482