Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1615

Support HOP and SESSION in the GROUP BY clause

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0
    • Component/s: None
    • Labels:
      None

      Description

      CALCITE-1603 has finished the heavy liftings of supporting the TUMBLE function in the GROUP BY clause. This jira proposes to add supports for the HOP and the SESSION functions in Calcite as well.

        Issue Links

          Activity

          Hide
          wheat9 Haohui Mai added a comment -

          Somehow the Github bot is not working. The patch is available at https://github.com/apache/calcite/pull/375

          Show
          wheat9 Haohui Mai added a comment - Somehow the Github bot is not working. The patch is available at https://github.com/apache/calcite/pull/375
          Hide
          wheat9 Haohui Mai added a comment -

          Julian Hyde would you mind taking a look? This implementation essentially comes from https://github.com/julianhyde/calcite/commits/768-hop. This PR contains the parts that are not in CALCITE-1603. Thanks.

          Show
          wheat9 Haohui Mai added a comment - Julian Hyde would you mind taking a look? This implementation essentially comes from https://github.com/julianhyde/calcite/commits/768-hop . This PR contains the parts that are not in CALCITE-1603 . Thanks.
          Hide
          julianhyde Julian Hyde added a comment -

          Can you add TUMBLE, HOP, SESSION etc. functions to reference.md? They are not "grouping functions" or "window functions" or "aggregate functions" so you will need a new section. And also modify the syntax of the GROUP BY clause.

          Show
          julianhyde Julian Hyde added a comment - Can you add TUMBLE, HOP, SESSION etc. functions to reference.md? They are not "grouping functions" or "window functions" or "aggregate functions" so you will need a new section. And also modify the syntax of the GROUP BY clause.
          Hide
          julianhyde Julian Hyde added a comment -

          Let's try to get this into release 1.12.

          Show
          julianhyde Julian Hyde added a comment - Let's try to get this into release 1.12.
          Hide
          julianhyde Julian Hyde added a comment -

          Haohui Mai, I saw you added non-reserved keywords for HOP, SESSION_START etc. I don't think we need keywords; they're just function names. If you don't mind I'll try backing out that part of the change. Without keywords this change will have less impact on people who just want to use core SQL.

          Show
          julianhyde Julian Hyde added a comment - Haohui Mai , I saw you added non-reserved keywords for HOP, SESSION_START etc. I don't think we need keywords; they're just function names. If you don't mind I'll try backing out that part of the change. Without keywords this change will have less impact on people who just want to use core SQL.
          Hide
          wheat9 Haohui Mai added a comment - - edited

          That sounds good to me. Please go ahead.

          Please feel free to create a jira and assign it to me.

          Show
          wheat9 Haohui Mai added a comment - - edited That sounds good to me. Please go ahead. Please feel free to create a jira and assign it to me.
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/49888a6c . Thanks for the PR, Haohui Mai !
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.12.0 (2017-03-24).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.12.0 (2017-03-24).
          Hide
          julianhyde Julian Hyde added a comment -

          Some tests were missed, and have been in fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/a11d1405 along with CALCITE-1761.

          Show
          julianhyde Julian Hyde added a comment - Some tests were missed, and have been in fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/a11d1405 along with CALCITE-1761 .

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development