Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0
    • Component/s: stream
    • Labels:
      None

      Description

      Recent changes in Flink (e.g., FLINK-4691) has added the support for tumbling windows in streams.

      This jira proposes to add supports for parsing the tumbling window in the group by clause as suggested in http://calcite.apache.org/docs/stream.html, so that it is possible to expose tumble window support at the SQL layer in Flink.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          You should definitely build on the work I did in https://github.com/julianhyde/calcite/commits/768-hop.

          Show
          julianhyde Julian Hyde added a comment - You should definitely build on the work I did in https://github.com/julianhyde/calcite/commits/768-hop .
          Hide
          wheat9 Haohui Mai added a comment -

          Sure. My plan is to build on top of the branch – for this jira I plan to only include the changes for tumbling window and put the other parts of the branch into separate jiras. Does it sound good to you Julian Hyde?

          Show
          wheat9 Haohui Mai added a comment - Sure. My plan is to build on top of the branch – for this jira I plan to only include the changes for tumbling window and put the other parts of the branch into separate jiras. Does it sound good to you Julian Hyde ?
          Hide
          julianhyde Julian Hyde added a comment -

          Yes. Get the functionality working in that branch then I can rebase / squash / carve up into discrete commits.

          Show
          julianhyde Julian Hyde added a comment - Yes. Get the functionality working in that branch then I can rebase / squash / carve up into discrete commits.
          Hide
          julianhyde Julian Hyde added a comment -

          Haohui Mai, I saw your PR https://github.com/apache/calcite/pull/368/. Am I correct that it parses, validates, translates sql-to-rel but does not execute? A full implementation would add a test to StreamTest. You don't need to go all the way, but it would help if you clarify how much of the work is done.

          Also, I'm grateful that you built on top of my work towards CALCITE-768 but can you give me credit in the commit. Your pull request has one commit and it names you as sole author.

          Show
          julianhyde Julian Hyde added a comment - Haohui Mai , I saw your PR https://github.com/apache/calcite/pull/368/ . Am I correct that it parses, validates, translates sql-to-rel but does not execute? A full implementation would add a test to StreamTest. You don't need to go all the way, but it would help if you clarify how much of the work is done. Also, I'm grateful that you built on top of my work towards CALCITE-768 but can you give me credit in the commit. Your pull request has one commit and it names you as sole author.
          Hide
          wheat9 Haohui Mai added a comment -

          Am I correct that it parses, validates, translates sql-to-rel but does not execute?

          Correct. The execution requires implementing the TUMBLE_START / TUMBLE_END / TUMBLE functions in avatica. It might make sense to separate it out to another jira.

          but can you give me credit in the commit.

          Absolutely. As I mentioned in PR itself, it was basically a rebase of your previous work – I have changed the commit message to call you out explicitly.

          Show
          wheat9 Haohui Mai added a comment - Am I correct that it parses, validates, translates sql-to-rel but does not execute? Correct. The execution requires implementing the TUMBLE_START / TUMBLE_END / TUMBLE functions in avatica. It might make sense to separate it out to another jira. but can you give me credit in the commit. Absolutely. As I mentioned in PR itself, it was basically a rebase of your previous work – I have changed the commit message to call you out explicitly.
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/bc232c26 . Thanks for the PR, Haohui Mai !
          Hide
          julianhyde Julian Hyde added a comment -

          Haohui Mai, Was there anything in https://github.com/julianhyde/calcite/commits/768-hop that you did not use? If so, could you create a copy of that branch and rebase so that the new branch contains just the deltas?

          Show
          julianhyde Julian Hyde added a comment - Haohui Mai , Was there anything in https://github.com/julianhyde/calcite/commits/768-hop that you did not use? If so, could you create a copy of that branch and rebase so that the new branch contains just the deltas?
          Hide
          wheat9 Haohui Mai added a comment -

          The only things that are left out are recognizing the HOP and SESSION functions. They are fairly straightforward to add. I'll add them in another jira.

          Show
          wheat9 Haohui Mai added a comment - The only things that are left out are recognizing the HOP and SESSION functions. They are fairly straightforward to add. I'll add them in another jira.
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.12.0 (2017-03-24).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.12.0 (2017-03-24).

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development