[CALCITE-1353] first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: avatica-1.8.0
• Fix Version/s: avatica-1.10.0
• Component/s: avatica
• Assignee: Josh Elser
• Reporter: Francis Chuang
• Created: 22/Aug/16 06:18
• Updated: 30/May/17 16:23
• Resolved: 10/Apr/17 00:39

Description

In the protobuf definition for ExecuteRequest, the first_frame_max_size parameter is typed as an uint64. See https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130. For consistency, it should be an int32.

Similar parameters relating to the frame size are all typed as int32.

For a PrepareAndExecuteRequest, first_frame_max_size is a{{int32}}: https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78

For a FetchRequest, frame_max_size is a int32: https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96

Issue Links

• is broken by: CALCITE-1243 max_row_count in protobuf Requests should be signed int
• links to: GitHub Pull Request #5
• links to: PR 319