[CALCITE-1243] max_row_count in protobuf Requests should be signed int

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: avatica-1.8.0
• Component/s: avatica
• Assignee: Josh Elser
• Reporter: Duo Xu
• Created: 18/May/16 20:52
• Updated: 29/Apr/19 17:14
• Resolved: 19/May/16 18:15

Description

Looking at the source code, the maxRowCount is signed. And based on the code comments,
/** Creates a result set with maxRowCount.
*

• <p>If {@code maxRowCount}

  is -2 (

  {@link JdbcMeta#UNLIMITED_COUNT}

  ),

• returns an unlimited number of rows in a single frame; any other
• negative value (typically -1) returns an unlimited number of rows
• in frames of the default frame size. */

we can pass -2 to return all the rows in a single batch. But the proto file define this parameter as unsigned. We need to make it consistent with the internal code.

Issue Links

• breaks: CALCITE-1353 first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.