Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-797

IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.4.0
    • Component/s: bookkeeper-stats
    • Labels:
      None

      Description

      The implementation of CodahaleOpStatsLogger#toOpStatsData() passes incorrect parameters to codahale's Snapshot#getValue method, resulting in the following runtime exception:

      java.lang.IllegalArgumentException: 10.0 is not in [0..1]
      at com.codahale.metrics.Snapshot.getValue(Snapshot.java:52)
      at org.apache.bookkeeper.stats.CodahaleOpStatsLogger.toOpStatsData(CodahaleOpStatsLogger.java:64)
      ...

      In order to pass quantiles as [0..1] values, as expected by codahale metrics library, we must divide parameters by 100 before passing them.

        Attachments

        1. codahale-stats-opstats-fix.patch
          3 kB
          Matthieu Morel
        2. codahale-stats-opstats-fix.patch
          3 kB
          Matthieu Morel

          Activity

            People

            • Assignee:
              mmorel Matthieu Morel
              Reporter:
              mmorel Matthieu Morel
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: