[BOOKKEEPER-797] IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3.0
• Fix Version/s: 4.4.0
• Component/s: bookkeeper-stats
• Assignee: Matthieu Morel
• Reporter: Matthieu Morel
• Created: 19/Nov/14 13:38
• Updated: 16/May/16 21:47
• Resolved: 19/Nov/14 17:01

Description

The implementation of CodahaleOpStatsLogger#toOpStatsData() passes incorrect parameters to codahale's Snapshot#getValue method, resulting in the following runtime exception:

java.lang.IllegalArgumentException: 10.0 is not in [0..1]
at com.codahale.metrics.Snapshot.getValue(Snapshot.java:52)
at org.apache.bookkeeper.stats.CodahaleOpStatsLogger.toOpStatsData(CodahaleOpStatsLogger.java:64)
...

In order to pass quantiles as [0..1] values, as expected by codahale metrics library, we must divide parameters by 100 before passing them.