Bigtop
  1. Bigtop
  2. BIGTOP-433

Make variables used in build/install scripts consistent

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.2.0, 0.3.0
    • Fix Version/s: None
    • Component/s: general
    • Labels:
      None

      Description

      I was working on some scripts across different packages and the inconsistencies make it hard to work efficiently.
      Each script uses a different meaning for variables (ex: $PREFIX/$LIB_DIR vs $LIB_DIR vs $PREFIX/$<PROJECT>_DIR).

      Having a consistent set of variables would make it much easier to edit these scripts.

        Activity

        Roman Shaposhnik made changes -
        Fix Version/s 0.6.0 [ 12323895 ]
        Roman Shaposhnik made changes -
        Fix Version/s 0.6.0 [ 12323895 ]
        Fix Version/s 0.5.0 [ 12321865 ]
        Hide
        Anatoli Fomenko added a comment -

        Following Bruno's comments in BIGTOP-695, I'm using the following guidelines while making the install script consistent across different packages:

        1. Use spec and rules files' install sections to determine what variables are passed to the install scripts
        2. Keep $PREFIX out of the variable definitions in the install files, to reduce duplicate work in spec and rules files
        3. Use common variable names, e.g. $LIB_DIR, $MAN_DIR, $DOC_DIR, etc.
        4. Remove unused variables
        Show
        Anatoli Fomenko added a comment - Following Bruno's comments in BIGTOP-695 , I'm using the following guidelines while making the install script consistent across different packages: Use spec and rules files' install sections to determine what variables are passed to the install scripts Keep $PREFIX out of the variable definitions in the install files, to reduce duplicate work in spec and rules files Use common variable names, e.g. $LIB_DIR, $MAN_DIR, $DOC_DIR, etc. Remove unused variables
        Hide
        Anatoli Fomenko added a comment -

        I plan to create separate subtasks for each project that need install script variables adjustment, for more convenient tracking and reviwing: flume, hadoop, oozie, zookeeper, giraph, sqoop, hue, mahout, hbase.

        Show
        Anatoli Fomenko added a comment - I plan to create separate subtasks for each project that need install script variables adjustment, for more convenient tracking and reviwing: flume, hadoop, oozie, zookeeper, giraph, sqoop, hue, mahout, hbase.
        Anatoli Fomenko made changes -
        Assignee Anatoli Fomenko [ anatoli.fomenko ]
        Hide
        Anatoli Fomenko added a comment - - edited

        Install scripts for he following projects use $LIB_DIR with included $PREFIX: datafu, tomcat, whirr, hive, jsvc, pig. It looks like it's a convention that makes sense to follow.

        Show
        Anatoli Fomenko added a comment - - edited Install scripts for he following projects use $LIB_DIR with included $PREFIX: datafu, tomcat, whirr, hive, jsvc, pig. It looks like it's a convention that makes sense to follow.
        Roman Shaposhnik made changes -
        Fix Version/s 0.5.0 [ 12321865 ]
        Fix Version/s 0.4.0 [ 12318889 ]
        Gavin made changes -
        Field Original Value New Value
        Workflow no-reopen-closed, patch-avail [ 12656862 ] patch-available, re-open possible [ 12666126 ]
        Bruno Mahé created issue -

          People

          • Assignee:
            Anatoli Fomenko
            Reporter:
            Bruno Mahé
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development