Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: general
    • Labels:
      None
    1. BIGTOP-704.patch
      5 kB
      Anatoli Fomenko
    2. BIGTOP-704.patch
      3 kB
      Anatoli Fomenko

      Activity

      Hide
      Anatoli Fomenko added a comment -

      Patch submitted. Please review.
      Thank you.

      Show
      Anatoli Fomenko added a comment - Patch submitted. Please review. Thank you.
      Hide
      Bruno Mahé added a comment -

      Was it tested?
      It looks like you forgot to update the rules file as well as the spec file.

      From the spec file:

      sh -x %{SOURCE2} \
                --build-dir=build \
                --doc-dir=$RPM_BUILD_ROOT%{doc_pig} \
                --prefix=$RPM_BUILD_ROOT
      

      "--doc-dir" should not have $RPM_BUILD_ROOT since you are now prefixing it with the prefix from within the install script.

      From the rules file:

      	sh -x debian/install_pig.sh \
      	  --build-dir=build \
      	  --prefix=debian/${pig_pkg_name} \
                --doc-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name} \
                --examples-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name}/examples
      

      Same here with debian/$

      {pig_pkg_name}

      for --doc-dir and --examples-dir

      Show
      Bruno Mahé added a comment - Was it tested? It looks like you forgot to update the rules file as well as the spec file. From the spec file: sh -x %{SOURCE2} \ --build-dir=build \ --doc-dir=$RPM_BUILD_ROOT%{doc_pig} \ --prefix=$RPM_BUILD_ROOT "--doc-dir" should not have $RPM_BUILD_ROOT since you are now prefixing it with the prefix from within the install script. From the rules file: sh -x debian/install_pig.sh \ --build-dir=build \ --prefix=debian/${pig_pkg_name} \ --doc-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name} \ --examples-dir=debian/${pig_pkg_name}/usr/share/doc/${pig_pkg_name}/examples Same here with debian/$ {pig_pkg_name} for --doc-dir and --examples-dir
      Hide
      Anatoli Fomenko added a comment -

      New patch version attached. rules and spec files have been adjusted per the comments.
      Please review. Thank you.

      Show
      Anatoli Fomenko added a comment - New patch version attached. rules and spec files have been adjusted per the comments. Please review. Thank you.
      Hide
      Bruno Mahé added a comment -

      +1
      Thanks!

      Show
      Bruno Mahé added a comment - +1 Thanks!

        People

        • Assignee:
          Anatoli Fomenko
          Reporter:
          Anatoli Fomenko
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development