Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2722

Remove workaround allowing build by root in Tez

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: build, tez
    • Labels:
      None

      Description

      We've applied a workaround since 1.0.0 to allow building Tez as root(BIGTOP-1815). By that time there's no user namespace in docker yet. But now the feature is available, hence we should drop the workaround.
      We encountered the same issue when building Zeppelin 0.7(BIGTOP-2689), which has been addressed by specifying --user jenkins when starting docker containers. Therefore the fix should be simply remove the allow-root configuration.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user evans-ye opened a pull request:

          https://github.com/apache/bigtop/pull/190

          BIGTOP-2722. Remove workaround allowing build by root in Tez

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/evans-ye/bigtop BIGTOP-2722

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/190.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #190


          commit 9f41a8f5c3cd991dbce192ad83fca4d15a77eb55
          Author: Evans Ye <evansye@apache.org>
          Date: 2017-03-27T19:08:14Z

          BIGTOP-2722. Remove workaround allowing build by root in Tez


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user evans-ye opened a pull request: https://github.com/apache/bigtop/pull/190 BIGTOP-2722 . Remove workaround allowing build by root in Tez You can merge this pull request into a Git repository by running: $ git pull https://github.com/evans-ye/bigtop BIGTOP-2722 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #190 commit 9f41a8f5c3cd991dbce192ad83fca4d15a77eb55 Author: Evans Ye <evansye@apache.org> Date: 2017-03-27T19:08:14Z BIGTOP-2722 . Remove workaround allowing build by root in Tez
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ejono commented on the issue:

          https://github.com/apache/bigtop/pull/190

          LGTM, thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user ejono commented on the issue: https://github.com/apache/bigtop/pull/190 LGTM, thanks!
          Hide
          rvs Roman Shaposhnik added a comment -

          LGTM! Please push ASAP!

          Show
          rvs Roman Shaposhnik added a comment - LGTM! Please push ASAP!
          Hide
          evans_ye Evans Ye added a comment -

          Pushed to the master. Thanks for the review.

          Show
          evans_ye Evans Ye added a comment - Pushed to the master. Thanks for the review.

            People

            • Assignee:
              evans_ye Evans Ye
              Reporter:
              evans_ye Evans Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development