Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      I deployed and ran Spark on Zeppelin using master branch, then got the following error:

      Spark 2.1.0 is not supported

      This is because Zeppelin 0.6.2 supports only Spark version less than 2.1.0. Zeppelin 0.7 supports Spark 2.1.0.

        Issue Links

          Activity

          Hide
          warwithin YoungWoo Kim added a comment -

          Kengo Seki, Patch attached for upgrading Z version to 0.7.0. After all, we'd upgrade to 0.7.1. see http://apache-zeppelin-dev-mailing-list.75694.x6.nabble.com/DISCUSS-0-7-1-release-td22116.html

          Show
          warwithin YoungWoo Kim added a comment - Kengo Seki , Patch attached for upgrading Z version to 0.7.0. After all, we'd upgrade to 0.7.1. see http://apache-zeppelin-dev-mailing-list.75694.x6.nabble.com/DISCUSS-0-7-1-release-td22116.html
          Hide
          evans_ye Evans Ye added a comment -

          Looks good to me without testing.
          I think we need PR auto testing mechanism here to speed up our project development process.
          jay vyas can you pass your knowledge to us for enabling something like that?
          I remember you're the one who helped enabling git hook.

          Show
          evans_ye Evans Ye added a comment - Looks good to me without testing. I think we need PR auto testing mechanism here to speed up our project development process. jay vyas can you pass your knowledge to us for enabling something like that? I remember you're the one who helped enabling git hook.
          Hide
          jonathak Jonathan Kelly added a comment - - edited

          Sorry for the slow response. It mostly looks good to me, though I have not tested it yet either.

          I do have one question/comment though. Why did you make the changes to how the hbase version is overridden in the do-component-build script? I think what you want to do instead of removing that 'find' line and adding the -Dhbase.hbase.version and -Dhbase.hadoop.version properties to BUILD_OPTS is to change the existing 'find' line and make it replace these properties in that way. That is,

          -t="hbase.version"
          -find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HBASE_VERSION}</$t>#" {} \;
          +t="hbase.hbase.version"
          +find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HBASE_VERSION}</$t>#" {} \;
          +t="hbase.hadoop.version"
          +find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HADOOP_VERSION}</$t>#" {} \;
          
          Show
          jonathak Jonathan Kelly added a comment - - edited Sorry for the slow response. It mostly looks good to me, though I have not tested it yet either. I do have one question/comment though. Why did you make the changes to how the hbase version is overridden in the do-component-build script? I think what you want to do instead of removing that 'find' line and adding the -Dhbase.hbase.version and -Dhbase.hadoop.version properties to BUILD_OPTS is to change the existing 'find' line and make it replace these properties in that way. That is, -t="hbase.version" -find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HBASE_VERSION}</$t>#" {} \; +t="hbase.hbase.version" +find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HBASE_VERSION}</$t>#" {} \; +t="hbase.hadoop.version" +find . -name pom.xml -exec sed -i "s#<$t>.*</$t>#<$t>${HADOOP_VERSION}</$t>#" {} \;
          Hide
          warwithin YoungWoo Kim added a comment -

          Jonathan Kelly I just prefer to use concise way rather than to use commands like find, sed or etc. but, the way that you suggested is more consistent. Good point! I'll revise the patch and re-submit a new patch shortly. Thanks.

          Show
          warwithin YoungWoo Kim added a comment - Jonathan Kelly I just prefer to use concise way rather than to use commands like find, sed or etc. but, the way that you suggested is more consistent. Good point! I'll revise the patch and re-submit a new patch shortly. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user youngwookim opened a pull request:

          https://github.com/apache/bigtop/pull/181

          BIGTOP-2689: Upgrade Zeppelin to version 0.7

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/youngwookim/bigtop BIGTOP-2689

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/181.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #181


          commit da0d9faf61cc9154cfd456a69f14c6a2fe5f0430
          Author: Youngwoo Kim <ywkim@apache.org>
          Date: 2017-02-07T03:10:28Z

          BIGTOP-2689: Upgrade Zeppelin to version 0.7


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user youngwookim opened a pull request: https://github.com/apache/bigtop/pull/181 BIGTOP-2689 : Upgrade Zeppelin to version 0.7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/youngwookim/bigtop BIGTOP-2689 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #181 commit da0d9faf61cc9154cfd456a69f14c6a2fe5f0430 Author: Youngwoo Kim <ywkim@apache.org> Date: 2017-02-07T03:10:28Z BIGTOP-2689 : Upgrade Zeppelin to version 0.7
          Hide
          warwithin YoungWoo Kim added a comment -

          Jonathan Kelly I've revised the patch and created a PR. Unfortunately, building Z on docker is still failing:

          [INFO] $ bower install --silent && grunt googlefonts
          [INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
          [ERROR] [{
          [ERROR]   "code": "ESUDO",
          [ERROR]   "details": "Since bower is a user command, there is no need to execute it with superuser permissions.\nIf you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.\n\nhttp://www.joyent.com/blog/installing-node-and-npm\nhttps://gist.github.com/isaacs/579814\n\nYou can however run a command with sudo using --allow-root option",
          [ERROR]   "id": "ESUDO",
          [ERROR]   "level": "error",
          [ERROR]   "data": {},
          [ERROR]   "message": "Cannot be run with sudo",
          [ERROR]   "stacktrace": "Error: Cannot be run with sudo\n    at createError (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/util/createError.js:4:15)\n    at rootCheck (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/util/rootCheck.js:26:24)\n    at Object.<anonymous> (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/bin/bower.js:33:1)\n    at Module._compile (module.js:570:32)\n    at Object.Module._extensions..js (module.js:579:10)\n    at Module.load (module.js:487:32)\n    at tryModuleLoad (module.js:446:12)\n    at Function.Module._load (module.js:438:3)\n    at Module.require (module.js:497:17)\n    at require (internal/module.js:20:19)"
          [ERROR] }]
          [ERROR] error Command failed with exit code 1.
          

          Any idea on this?

          Show
          warwithin YoungWoo Kim added a comment - Jonathan Kelly I've revised the patch and created a PR. Unfortunately, building Z on docker is still failing: [INFO] $ bower install --silent && grunt googlefonts [INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. [ERROR] [{ [ERROR] "code": "ESUDO", [ERROR] "details": "Since bower is a user command, there is no need to execute it with superuser permissions.\nIf you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.\n\nhttp://www.joyent.com/blog/installing-node-and-npm\nhttps://gist.github.com/isaacs/579814\n\nYou can however run a command with sudo using --allow-root option", [ERROR] "id": "ESUDO", [ERROR] "level": "error", [ERROR] "data": {}, [ERROR] "message": "Cannot be run with sudo", [ERROR] "stacktrace": "Error: Cannot be run with sudo\n at createError (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/util/createError.js:4:15)\n at rootCheck (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/util/rootCheck.js:26:24)\n at Object.<anonymous> (/bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.7.0/zeppelin-web/node_modules/bower/lib/bin/bower.js:33:1)\n at Module._compile (module.js:570:32)\n at Object.Module._extensions..js (module.js:579:10)\n at Module.load (module.js:487:32)\n at tryModuleLoad (module.js:446:12)\n at Function.Module._load (module.js:438:3)\n at Module.require (module.js:497:17)\n at require (internal/module.js:20:19)" [ERROR] }] [ERROR] error Command failed with exit code 1. Any idea on this?
          Hide
          jonathak Jonathan Kelly added a comment -

          YoungWoo Kim, thanks for adding a PR. Much easier to review and comment on that way! Though now I don't have any more comments to annotate it with because it LGTM now.

          Sorry, I'm not exactly sure what to do about your build failure, as I'm not building in docker. However, it looks like this should help you: https://github.com/bower/bower/issues/1752

          Show
          jonathak Jonathan Kelly added a comment - YoungWoo Kim , thanks for adding a PR. Much easier to review and comment on that way! Though now I don't have any more comments to annotate it with because it LGTM now. Sorry, I'm not exactly sure what to do about your build failure, as I'm not building in docker. However, it looks like this should help you: https://github.com/bower/bower/issues/1752
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/181#discussion_r103611570

          — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh —
          @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/webapps

          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war
          -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/*
          +cp -a $

          {BUILD_DIR}

          /build/dist/

          {bin,interpreter,lib,zeppelin-web-0.7.0.war}

          $PREFIX/$LIB_DIR/
          — End diff –

          use * instead of hardcoding `0.7.0`?

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on a diff in the pull request: https://github.com/apache/bigtop/pull/181#discussion_r103611570 — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh — @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/webapps -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/* +cp -a $ {BUILD_DIR} /build/dist/ {bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/ — End diff – use * instead of hardcoding `0.7.0`?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user evans-ye commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/181#discussion_r103716786

          — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh —
          @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/webapps

          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war
          -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/*
          +cp -a $

          {BUILD_DIR}

          /build/dist/

          {bin,interpreter,lib,zeppelin-web-0.7.0.war}

          $PREFIX/$LIB_DIR/
          — End diff –

          Sounds like a good suggestion. Or we can replace it by ZEPPELIN_VERSION?

          Show
          githubbot ASF GitHub Bot added a comment - Github user evans-ye commented on a diff in the pull request: https://github.com/apache/bigtop/pull/181#discussion_r103716786 — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh — @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/webapps -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/* +cp -a $ {BUILD_DIR} /build/dist/ {bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/ — End diff – Sounds like a good suggestion. Or we can replace it by ZEPPELIN_VERSION?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ejono commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/181#discussion_r103763248

          — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh —
          @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/
          install -d -m 0755 $PREFIX/var/run/zeppelin/webapps

          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/*
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar
          -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $

          {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war
          -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}

          /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/*
          +cp -a $

          {BUILD_DIR}

          /build/dist/

          {bin,interpreter,lib,zeppelin-web-0.7.0.war}

          $PREFIX/$LIB_DIR/
          — End diff –

          Ah, I missed that. Good catch, @felixcheung. +1 on using $

          {ZEPPELIN_VERSION}

          .

          Show
          githubbot ASF GitHub Bot added a comment - Github user ejono commented on a diff in the pull request: https://github.com/apache/bigtop/pull/181#discussion_r103763248 — Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh — @@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/ install -d -m 0755 $PREFIX/var/run/zeppelin/webapps -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */bin/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */interpreter/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz */lib/* -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-server*.jar -tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf $ {BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz *zeppelin-web*.war -tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR} /zeppelin-distribution/target/zeppelin-*.tar.gz */notebook/* +cp -a $ {BUILD_DIR} /build/dist/ {bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/ — End diff – Ah, I missed that. Good catch, @felixcheung. +1 on using $ {ZEPPELIN_VERSION} .
          Hide
          jonathak Jonathan Kelly added a comment -

          Other than Felix Cheung's comment about not hardcoding 0.7.0 in the install script, this LGTM. The build also works for me, and I tested it successfully on EMR.

          Show
          jonathak Jonathan Kelly added a comment - Other than Felix Cheung 's comment about not hardcoding 0.7.0 in the install script, this LGTM. The build also works for me, and I tested it successfully on EMR.
          Hide
          evans_ye Evans Ye added a comment -

          Regarding to Z build fail on Docker. We got exactly a same issue in building tez-ui, which we applied a workaround for it...
          Please see BIGTOP-1815. Shall we apply the same workaround here?

          Show
          evans_ye Evans Ye added a comment - Regarding to Z build fail on Docker. We got exactly a same issue in building tez-ui, which we applied a workaround for it... Please see BIGTOP-1815 . Shall we apply the same workaround here?
          Hide
          jonathak Jonathan Kelly added a comment -

          Ah, I didn't know about that fix in tez-ui. That does sound like something we can/should do in Zeppelin as well. It should probably be done in a separate JIRA though.

          Show
          jonathak Jonathan Kelly added a comment - Ah, I didn't know about that fix in tez-ui. That does sound like something we can/should do in Zeppelin as well. It should probably be done in a separate JIRA though.
          Hide
          evans_ye Evans Ye added a comment -

          Agree, Jonathan Kelly
          BTW, I guess a better way to fix this is to run builds in docker by non-root. Docker has user namespace now.
          I tried the follow steps to build as non-root and it works:

          git clone https://github.com/apache/bigtop.git
          cd bigtop
          docker run --rm -u jenkins -v `pwd`:/ws --workdir /ws bigtop/slaves:trunk-ubuntu-16.04 bash -c '. /etc/profile.d/bigtop.sh; ./gradlew allclean zeppelin-pkg'
          

          Perhaps we should shift to the right direction from now on.

          Show
          evans_ye Evans Ye added a comment - Agree, Jonathan Kelly BTW, I guess a better way to fix this is to run builds in docker by non-root. Docker has user namespace now. I tried the follow steps to build as non-root and it works: git clone https: //github.com/apache/bigtop.git cd bigtop docker run --rm -u jenkins -v `pwd`:/ws --workdir /ws bigtop/slaves:trunk-ubuntu-16.04 bash -c '. /etc/profile.d/bigtop.sh; ./gradlew allclean zeppelin-pkg' Perhaps we should shift to the right direction from now on.
          Hide
          felixcheung Felix Cheung added a comment -

          sounds like the right thing to do. how about I create a patch on the readme for that?

          Show
          felixcheung Felix Cheung added a comment - sounds like the right thing to do. how about I create a patch on the readme for that?
          Hide
          jonathak Jonathan Kelly added a comment -

          Oh, OK. Yeah, if it's that easy to run as non-root, that would certainly be better than having workarounds like this with --allow-root.

          Show
          jonathak Jonathan Kelly added a comment - Oh, OK. Yeah, if it's that easy to run as non-root, that would certainly be better than having workarounds like this with --allow-root.
          Hide
          warwithin YoungWoo Kim added a comment -

          Thanks for your comments Felix Cheung, Jonathan Kelly, Evans Ye I've revised the PR and attached a new patch as well.

          Show
          warwithin YoungWoo Kim added a comment - Thanks for your comments Felix Cheung , Jonathan Kelly , Evans Ye I've revised the PR and attached a new patch as well.
          Hide
          jonathak Jonathan Kelly added a comment -

          Thanks, LGTM!

          Show
          jonathak Jonathan Kelly added a comment - Thanks, LGTM!
          Hide
          warwithin YoungWoo Kim added a comment -

          Thanks Jonathan Kelly Let me commit this.

          Show
          warwithin YoungWoo Kim added a comment - Thanks Jonathan Kelly Let me commit this.

            People

            • Assignee:
              warwithin YoungWoo Kim
              Reporter:
              sekikn Kengo Seki
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development