Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment, tests
    • Labels:
      None

      Description

      Similar updates to what we did for the zk charm (BIGTOP-2575). Update the Juju charm for Kafka:

      • ensure we deploy correct kafka charm and watch for correct status during tests
      • use new syntax for executing smoke tests
      • include the network interface binding test (previously skipped)
      • report the application version for status output

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kwmonroe opened a pull request:

          https://github.com/apache/bigtop/pull/157

          BIGTOP-2577: kafka charm test updates

          Similar updates to what we did for the zk charm (BIGTOP-2575). Update the Juju charm for Kafka:

          • update readme with language consistent with other bigtop charms
          • ensure we deploy correct kafka charm and watch for correct status during tests
          • use new syntax for executing smoke tests
          • include the network interface binding test (previously skipped)
          • report the application version for status output

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/juju-solutions/bigtop bug/k-cwr-fixes

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/157.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #157


          commit a02922859b69ec53f4c86debee0d5f29e1e1f7fa
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-29T19:06:38Z

          use bigtop and xenial charms in tests; use new action syntax; update nic test to be like the (better) one in the zookeeper charm

          commit 869ec1aa0add53c30366c300f3d32b0671919ca6
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-29T19:16:45Z

          update readme to be consistent with other bigtop charms

          commit 6d2d593be57d056964f07d12034447aa2ccfa5cf
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-11-07T18:59:08Z

          add app version for juju status output


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kwmonroe opened a pull request: https://github.com/apache/bigtop/pull/157 BIGTOP-2577 : kafka charm test updates Similar updates to what we did for the zk charm ( BIGTOP-2575 ). Update the Juju charm for Kafka: update readme with language consistent with other bigtop charms ensure we deploy correct kafka charm and watch for correct status during tests use new syntax for executing smoke tests include the network interface binding test (previously skipped) report the application version for status output You can merge this pull request into a Git repository by running: $ git pull https://github.com/juju-solutions/bigtop bug/k-cwr-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit a02922859b69ec53f4c86debee0d5f29e1e1f7fa Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-29T19:06:38Z use bigtop and xenial charms in tests; use new action syntax; update nic test to be like the (better) one in the zookeeper charm commit 869ec1aa0add53c30366c300f3d32b0671919ca6 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-29T19:16:45Z update readme to be consistent with other bigtop charms commit 6d2d593be57d056964f07d12034447aa2ccfa5cf Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-11-07T18:59:08Z add app version for juju status output
          Hide
          kwmonroe Kevin W Monroe added a comment -

          kafka charm rev 2 contains these fixes:

          https://jujucharms.com/kafka/

          This will be picked up and tested as part of the hadoop-kafka bundle tests on Nov 8:

          http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/index.html

          Show
          kwmonroe Kevin W Monroe added a comment - kafka charm rev 2 contains these fixes: https://jujucharms.com/kafka/ This will be picked up and tested as part of the hadoop-kafka bundle tests on Nov 8: http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/index.html
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user petevg commented on the issue:

          https://github.com/apache/bigtop/pull/157

          Tests work for me, and code looks good. LGTM/+1

          Show
          githubbot ASF GitHub Bot added a comment - Github user petevg commented on the issue: https://github.com/apache/bigtop/pull/157 Tests work for me, and code looks good. LGTM/+1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kwmonroe commented on the issue:

          https://github.com/apache/bigtop/pull/157

          Good catch in zookeeper – you suggested the better approach of relaxing the charm definition in the test.. Most recent commit should address your concerns. Thanks @petevg!

          Show
          githubbot ASF GitHub Bot added a comment - Github user kwmonroe commented on the issue: https://github.com/apache/bigtop/pull/157 Good catch in zookeeper – you suggested the better approach of relaxing the charm definition in the test.. Most recent commit should address your concerns. Thanks @petevg!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user petevg commented on the issue:

          https://github.com/apache/bigtop/pull/157

          My charms having been addressed, I am +1 on this one

          Show
          githubbot ASF GitHub Bot added a comment - Github user petevg commented on the issue: https://github.com/apache/bigtop/pull/157 My charms having been addressed, I am +1 on this one
          Hide
          ktsakalozos Konstantinos Tsakalozos added a comment -

          Tested again locally, LGTM +1

          Show
          ktsakalozos Konstantinos Tsakalozos added a comment - Tested again locally, LGTM +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/157

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/157
          Hide
          kwmonroe Kevin W Monroe added a comment -

          Latest kafka charm contains these updates:

          https://jujucharms.com/kafka/

          Verified on azure/gce (aws had unrelated infra issues):

          http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/802e41902fc2447699d1415ec4ff6c72/report.html

          Show
          kwmonroe Kevin W Monroe added a comment - Latest kafka charm contains these updates: https://jujucharms.com/kafka/ Verified on azure/gce (aws had unrelated infra issues): http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/802e41902fc2447699d1415ec4ff6c72/report.html

            People

            • Assignee:
              kwmonroe Kevin W Monroe
              Reporter:
              kwmonroe Kevin W Monroe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development