Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment, tests
    • Labels:
      None

      Description

      Update the Juju charm for Zookeeper:

      • ensure we deploy correct zk charm and watch for correct status during tests
      • use new syntax for executing smoke tests
      • include the network interface binding test (previously skipped)
      • report the application version for status output

        Issue Links

          Activity

          Hide
          kwmonroe Kevin W Monroe added a comment -

          Latest zk charm contains these updates:

          https://jujucharms.com/zookeeper/

          Verified on azure/gce (aws had unrelated infra issues):

          http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/802e41902fc2447699d1415ec4ff6c72/report.html

          Show
          kwmonroe Kevin W Monroe added a comment - Latest zk charm contains these updates: https://jujucharms.com/zookeeper/ Verified on azure/gce (aws had unrelated infra issues): http://data.vapour.ws/cwr-tests/results/bundle_hadoop_kafka/802e41902fc2447699d1415ec4ff6c72/report.html
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/bigtop/pull/156

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/bigtop/pull/156
          Hide
          ktsakalozos Konstantinos Tsakalozos added a comment -

          LGTM +1

          Show
          ktsakalozos Konstantinos Tsakalozos added a comment - LGTM +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user petevg commented on the issue:

          https://github.com/apache/bigtop/pull/156

          LGTM/+1

          Show
          githubbot ASF GitHub Bot added a comment - Github user petevg commented on the issue: https://github.com/apache/bigtop/pull/156 LGTM/+1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kwmonroe commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/156#discussion_r87508997

          — Diff: bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py —
          @@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase):
          def setUpClass(cls):
          cls.d = amulet.Deployment(series='xenial')

          • cls.d.add('zookeeper', charm='zookeeper', units=3)
            + cls.d.add('zk-test', charm='cs:xenial/zookeeper')
              • End diff –

          @petevg, i think there was an issue where test tooling might pick a series that was different than the one given in our Deployment(), so I got in the habit of being explicit. This did require tweaks to test locally, but it was better than stuff like cwr using the wrong charm.

          This doesn't seem to be needed anymore. Thanks for the catch, and thanks for improving my local test experience

          Fix incoming...

          Show
          githubbot ASF GitHub Bot added a comment - Github user kwmonroe commented on a diff in the pull request: https://github.com/apache/bigtop/pull/156#discussion_r87508997 — Diff: bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py — @@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase): def setUpClass(cls): cls.d = amulet.Deployment(series='xenial') cls.d.add('zookeeper', charm='zookeeper', units=3) + cls.d.add('zk-test', charm='cs:xenial/zookeeper') End diff – @petevg, i think there was an issue where test tooling might pick a series that was different than the one given in our Deployment(), so I got in the habit of being explicit. This did require tweaks to test locally, but it was better than stuff like cwr using the wrong charm. This doesn't seem to be needed anymore. Thanks for the catch, and thanks for improving my local test experience Fix incoming...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user petevg commented on a diff in the pull request:

          https://github.com/apache/bigtop/pull/156#discussion_r87495976

          — Diff: bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py —
          @@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase):
          def setUpClass(cls):
          cls.d = amulet.Deployment(series='xenial')

          • cls.d.add('zookeeper', charm='zookeeper', units=3)
            + cls.d.add('zk-test', charm='cs:xenial/zookeeper')
              • End diff –

          Think about this, is this truly the right pattern? I'd generally expect tests to integrate the code that I was just working on. These tests only exercise the published code – if I want to write some code, and then test it, I have to manually tweak the tests ...

          Show
          githubbot ASF GitHub Bot added a comment - Github user petevg commented on a diff in the pull request: https://github.com/apache/bigtop/pull/156#discussion_r87495976 — Diff: bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py — @@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase): def setUpClass(cls): cls.d = amulet.Deployment(series='xenial') cls.d.add('zookeeper', charm='zookeeper', units=3) + cls.d.add('zk-test', charm='cs:xenial/zookeeper') End diff – Think about this, is this truly the right pattern? I'd generally expect tests to integrate the code that I was just working on. These tests only exercise the published code – if I want to write some code, and then test it, I have to manually tweak the tests ...
          Hide
          kwmonroe Kevin W Monroe added a comment -

          zk charm rev 7 contains these fixes:

          https://jujucharms.com/zookeeper/

          This will be picked up and tested as part of the hadoop-spark and spark-processing bundle tests on Nov 8:

          http://data.vapour.ws/cwr-tests/results/index.html

          Show
          kwmonroe Kevin W Monroe added a comment - zk charm rev 7 contains these fixes: https://jujucharms.com/zookeeper/ This will be picked up and tested as part of the hadoop-spark and spark-processing bundle tests on Nov 8: http://data.vapour.ws/cwr-tests/results/index.html
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kwmonroe opened a pull request:

          https://github.com/apache/bigtop/pull/156

          BIGTOP-2575: zk charm test updates

          Update the Juju charm for Zookeeper:

          • ensure we deploy correct zk charm and watch for correct status during tests
          • use new syntax for executing smoke tests
          • include the network interface binding test (previously skipped)
          • report the application version for status output

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/juju-solutions/bigtop bug/zookeeper-action-fixes

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/156.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #156


          commit fc21e2c9aebc948246f1e1f8399eabf38c316d63
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-27T21:55:18Z

          check for correct action key in amulet tests

          commit 9f6e1f6508c16defa1a1fd7c7aa839c0bbf0d695
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-28T04:11:38Z

          tweak suboptimal message

          commit 20d58db4cc2600d1b0c61e0dc72ac7944935e357
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-28T19:45:10Z

          update amulet status message to match zk charm, wait for status message, increase bigtop smoke-test timeout

          commit f94be547798a7947c4ea751def7ed9012bd7805e
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-28T20:43:54Z

          net binding test updates

          • don't watch for status (we've missed it randomly); instead, sleep 2 minutes
            to let config-changed settle
          • binding to 0.0.0.0 works, so stop skipping the test

          commit 95d45da6203098deb4c32d92dcdf970c5136b7e6
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-28T20:49:33Z

          deploy separate zk when testing config changed

          Our charms and bundles use reset:false. To avoid potentially changing a
          desirable config without an admin knowing, make sure we deploy a 'zk-test'
          charm when testing config-changed events.

          commit 72101288eb4868b18d9da1e0ef997b96052133b2
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-10-28T21:37:03Z

          missed the zookeeper->zk-test rename

          commit 9293b065f2511b9d7432d0b59b38997ce8b3a2d8
          Author: Kevin W Monroe <kevin.monroe@canonical.com>
          Date: 2016-11-07T17:07:57Z

          lint, add app version for status, add .py suffix to tests


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kwmonroe opened a pull request: https://github.com/apache/bigtop/pull/156 BIGTOP-2575 : zk charm test updates Update the Juju charm for Zookeeper: ensure we deploy correct zk charm and watch for correct status during tests use new syntax for executing smoke tests include the network interface binding test (previously skipped) report the application version for status output You can merge this pull request into a Git repository by running: $ git pull https://github.com/juju-solutions/bigtop bug/zookeeper-action-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit fc21e2c9aebc948246f1e1f8399eabf38c316d63 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-27T21:55:18Z check for correct action key in amulet tests commit 9f6e1f6508c16defa1a1fd7c7aa839c0bbf0d695 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-28T04:11:38Z tweak suboptimal message commit 20d58db4cc2600d1b0c61e0dc72ac7944935e357 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-28T19:45:10Z update amulet status message to match zk charm, wait for status message, increase bigtop smoke-test timeout commit f94be547798a7947c4ea751def7ed9012bd7805e Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-28T20:43:54Z net binding test updates don't watch for status (we've missed it randomly); instead, sleep 2 minutes to let config-changed settle binding to 0.0.0.0 works, so stop skipping the test commit 95d45da6203098deb4c32d92dcdf970c5136b7e6 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-28T20:49:33Z deploy separate zk when testing config changed Our charms and bundles use reset:false. To avoid potentially changing a desirable config without an admin knowing, make sure we deploy a 'zk-test' charm when testing config-changed events. commit 72101288eb4868b18d9da1e0ef997b96052133b2 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-10-28T21:37:03Z missed the zookeeper->zk-test rename commit 9293b065f2511b9d7432d0b59b38997ce8b3a2d8 Author: Kevin W Monroe <kevin.monroe@canonical.com> Date: 2016-11-07T17:07:57Z lint, add app version for status, add .py suffix to tests

            People

            • Assignee:
              kwmonroe Kevin W Monroe
              Reporter:
              kwmonroe Kevin W Monroe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development