Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2142

Source cleanup: bigtop-repos shouldn't be top-level.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      bigtop-repos seems like an old, temp. hack which needs to be removed to avoid confusions. The only commit related to it is from BIGTOP-51, which was moving a bunch of stuff around. The only function this directory serves is to serve distributions file during apt creation. And even at this it's quite out-dated ie the version of the distribution is stuck at 0.1, etc.

      I'd suggest we generate this dynamically as a part of the build, so the version is correct and we don't have a stale template.

      1. BIGTOP-2142.1.patch
        2 kB
        Sergey Soldatov
      2. BIGTOP-2142.2.patch
        2 kB
        Sergey Soldatov
      3. BIGTOP-2142.3.patch
        2 kB
        Sergey Soldatov

        Activity

        Hide
        sergey.soldatov Sergey Soldatov added a comment -

        added distributions file generation to packages.gradle

        Show
        sergey.soldatov Sergey Soldatov added a comment - added distributions file generation to packages.gradle
        Hide
        cos Konstantin Boudnik added a comment - - edited

        Why the version is set to 0.3?

        Also, instead of masking new lines and all you can do

        +  writer.text ="""
        +Origin: Bigtop
        +Label: Bigtop
        +Suite: stable
        +Codename: bigtop
        +Version: 0.3
        +Architectures: i386 amd64 source
        +Components: contrib
        +Description: Bigtop""";
        
        Show
        cos Konstantin Boudnik added a comment - - edited Why the version is set to 0.3? Also, instead of masking new lines and all you can do + writer.text =""" +Origin: Bigtop +Label: Bigtop +Suite: stable +Codename: bigtop +Version: 0.3 +Architectures: i386 amd64 source +Components: contrib +Description: Bigtop""";
        Hide
        sergey.soldatov Sergey Soldatov added a comment -

        Fixed \ns, version is now based on the value from config.

        Show
        sergey.soldatov Sergey Soldatov added a comment - Fixed \ns, version is now based on the value from config.
        Hide
        cos Konstantin Boudnik added a comment -

        Looks good, thanks! Will commit it in a bit.

        Show
        cos Konstantin Boudnik added a comment - Looks good, thanks! Will commit it in a bit.
        Hide
        sergey.soldatov Sergey Soldatov added a comment -

        Added an extra line to avoid a message about missing CLRF

        Show
        sergey.soldatov Sergey Soldatov added a comment - Added an extra line to avoid a message about missing CLRF
        Hide
        sergey.soldatov Sergey Soldatov added a comment -

        Checked on 14.04 Ubuntu.

        Show
        sergey.soldatov Sergey Soldatov added a comment - Checked on 14.04 Ubuntu.
        Hide
        cos Konstantin Boudnik added a comment -

        Looks good, committing.

        Show
        cos Konstantin Boudnik added a comment - Looks good, committing.
        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master. Thanks!

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master. Thanks!

          People

          • Assignee:
            sergey.soldatov Sergey Soldatov
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development