Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: debian, ignite
    • Labels:
      None

      Description

      The service keep running then the package is purged from the system via apt-get purge.

      1. BIGTOP-2097.1.patch
        10 kB
        Olaf Flebbe
      2. BIGTOP-2097.2.patch
        11 kB
        Olaf Flebbe
      3. BIGTOP-2097.3.patch
        10 kB
        Olaf Flebbe
      4. BIGTOP-2097.4.patch
        11 kB
        Olaf Flebbe
      5. BIGTOP-2097-5.patch
        11 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Hi, I like to review this.

          Please generate a debian/ignite-hadoop.init file within the rules files.

          The install_init_scripts.sh is a bad workaround.

          Show
          oflebbe Olaf Flebbe added a comment - Hi, I like to review this. Please generate a debian/ignite-hadoop.init file within the rules files. The install_init_scripts.sh is a bad workaround.
          Hide
          cos Konstantin Boudnik added a comment -

          Olaf Flebbe, I agree the script is a pretty bad idea and I did a half-ass job, copying it from hbase component when added ignite packaging initially. Fixing HBase would be a story for another day though...

          Do you think ./zookeeper/zookeeper-server.init is Ok to follow? Would appreciate an advice if you're aware about a better practice for this. Thanks!

          Show
          cos Konstantin Boudnik added a comment - Olaf Flebbe , I agree the script is a pretty bad idea and I did a half-ass job, copying it from hbase component when added ignite packaging initially. Fixing HBase would be a story for another day though... Do you think ./zookeeper/zookeeper-server.init is Ok to follow? Would appreciate an advice if you're aware about a better practice for this. Thanks!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Konstantin Boudnik: My proposal to fix debian packaging. Feel free to modify for your needs. At least stopping and starting of the server process seems to work for debian now correctly.

          Additionally: I renamed the server package to ignite-hadoop-server (to be consistent with other packages. Since the ignite-hadoop-service package was more-or-less a NOOP before, should not matter, but your mileage may vary.

          The -doc package is empty. I fixed a path with in the install file, but it seems not enough. Maybe worth to be a new JIRA.

          Fixed the name and url of the project on control file

          Show
          oflebbe Olaf Flebbe added a comment - Konstantin Boudnik : My proposal to fix debian packaging. Feel free to modify for your needs. At least stopping and starting of the server process seems to work for debian now correctly. Additionally: I renamed the server package to ignite-hadoop-server (to be consistent with other packages. Since the ignite-hadoop-service package was more-or-less a NOOP before, should not matter, but your mileage may vary. The -doc package is empty. I fixed a path with in the install file, but it seems not enough. Maybe worth to be a new JIRA. Fixed the name and url of the project on control file
          Hide
          oflebbe Olaf Flebbe added a comment -

          Let me hijack this JIRA. Will rebase on top of BIGTOP-2107

          Show
          oflebbe Olaf Flebbe added a comment - Let me hijack this JIRA. Will rebase on top of BIGTOP-2107
          Hide
          oflebbe Olaf Flebbe added a comment -

          Will file a different JIRA to fix Redhat Init scripts ...

          Show
          oflebbe Olaf Flebbe added a comment - Will file a different JIRA to fix Redhat Init scripts ...
          Hide
          oflebbe Olaf Flebbe added a comment -

          Fix an impedance mismatch between RPM/DEB

          Show
          oflebbe Olaf Flebbe added a comment - Fix an impedance mismatch between RPM/DEB
          Hide
          cos Konstantin Boudnik added a comment -

          Looks real nice Olaf Flebbe! What a pleasure to watch an expert at work ... no seriously: thanks a lot for taking on this. I think over time we can use this as an example to fix the packaging and life-cycle management for the rest of the components, which are in a quite suboptimal shape right now.

          +1 from looking at it. I will test the it later in the day and chime in back

          Show
          cos Konstantin Boudnik added a comment - Looks real nice Olaf Flebbe ! What a pleasure to watch an expert at work ... no seriously: thanks a lot for taking on this. I think over time we can use this as an example to fix the packaging and life-cycle management for the rest of the components, which are in a quite suboptimal shape right now. +1 from looking at it. I will test the it later in the day and chime in back
          Hide
          cos Konstantin Boudnik added a comment -

          Olaf Flebbe, the patch is overall "go". I have fixed two small issues in the "-5" version of it:

          • ignite-hadoop-doc.docs should be called ignite-hadoop-doc.dirs
          • puppet recipe needs to refer to ignite-hadoop-service in the service section

          I will commit it over the next day or so, unless you will do it before or feel like not doing it yet. Thanks!

          Show
          cos Konstantin Boudnik added a comment - Olaf Flebbe , the patch is overall "go". I have fixed two small issues in the "-5" version of it: ignite-hadoop-doc.docs should be called ignite-hadoop-doc.dirs puppet recipe needs to refer to ignite-hadoop-service in the service section I will commit it over the next day or so, unless you will do it before or feel like not doing it yet. Thanks!
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          > ignite-hadoop-doc.docs should be called ignite-hadoop-doc.dirs

          No, that's not correct. Please read man dh_installdocs

          Show
          oflebbe Olaf Flebbe added a comment - - edited > ignite-hadoop-doc.docs should be called ignite-hadoop-doc.dirs No, that's not correct. Please read man dh_installdocs
          Hide
          cos Konstantin Boudnik added a comment - - edited

          The reason I said it, is because when the file is called "docs" the build throws an error (on Ubuntu at least) during the debuild phase.
          With two fixes I've mentioned I was able to build and deploy the packages without any glitches.

          Show
          cos Konstantin Boudnik added a comment - - edited The reason I said it, is because when the file is called "docs" the build throws an error (on Ubuntu at least) during the debuild phase. With two fixes I've mentioned I was able to build and deploy the packages without any glitches.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Could you please paste the error message?

          The docs file worked somehow for me. I am still wondering why the ignite-hadoop-doc package is empty.

          Show
          oflebbe Olaf Flebbe added a comment - Could you please paste the error message? The docs file worked somehow for me. I am still wondering why the ignite-hadoop-doc package is empty.
          Hide
          cos Konstantin Boudnik added a comment -

          Here's the message from the build

          make[1]: Leaving directory `/ws/output/ignite-hadoop/ignite-hadoop-1.5.1'
             dh_install
                  install -d debian/ignite-hadoop///usr/lib
                  cp -a debian/tmp//usr/lib/ignite-hadoop debian/ignite-hadoop///usr/lib/
                  cp -a debian/tmp//usr/bin/ignite-hadoop debian/ignite-hadoop///usr/bin/
                  cp -a debian/tmp//etc/ignite-hadoop debian/ignite-hadoop///etc/
             dh_installdocs
                  install -g 0 -o 0 -d debian/ignite-hadoop/usr/share/doc/ignite-hadoop
                  install -g 0 -o 0 -m 644 -p debian/copyright debian/ignite-hadoop/usr/share/doc/ignite-hadoop/copyright
                  install -g 0 -o 0 -d debian/ignite-hadoop-service/usr/share/doc/ignite-hadoop-service
                  install -g 0 -o 0 -m 644 -p debian/copyright debian/ignite-hadoop-service/usr/share/doc/ignite-hadoop-service/copyright
                  install -g 0 -o 0 -d debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc
                  cp -a /usr/share/docs/ignite-hadoop-docs debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc
          cp: cannot stat '/usr/share/docs/ignite-hadoop-docs': No such file or directory
          dh_installdocs: cp -a /usr/share/docs/ignite-hadoop-docs debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc returned exit code 1
          make: *** [binary] Error 2
          dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
          debuild: fatal error at line 1364:
          dpkg-buildpackage -rfakeroot -D -us -uc -b
           failed
          

          That's a good question, but it could be solved separately, for all I care

          Show
          cos Konstantin Boudnik added a comment - Here's the message from the build make[1]: Leaving directory `/ws/output/ignite-hadoop/ignite-hadoop-1.5.1' dh_install install -d debian/ignite-hadoop///usr/lib cp -a debian/tmp//usr/lib/ignite-hadoop debian/ignite-hadoop///usr/lib/ cp -a debian/tmp//usr/bin/ignite-hadoop debian/ignite-hadoop///usr/bin/ cp -a debian/tmp//etc/ignite-hadoop debian/ignite-hadoop///etc/ dh_installdocs install -g 0 -o 0 -d debian/ignite-hadoop/usr/share/doc/ignite-hadoop install -g 0 -o 0 -m 644 -p debian/copyright debian/ignite-hadoop/usr/share/doc/ignite-hadoop/copyright install -g 0 -o 0 -d debian/ignite-hadoop-service/usr/share/doc/ignite-hadoop-service install -g 0 -o 0 -m 644 -p debian/copyright debian/ignite-hadoop-service/usr/share/doc/ignite-hadoop-service/copyright install -g 0 -o 0 -d debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc cp -a /usr/share/docs/ignite-hadoop-docs debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc cp: cannot stat '/usr/share/docs/ignite-hadoop-docs': No such file or directory dh_installdocs: cp -a /usr/share/docs/ignite-hadoop-docs debian/ignite-hadoop-doc/usr/share/doc/ignite-hadoop-doc returned exit code 1 make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1364: dpkg-buildpackage -rfakeroot -D -us -uc -b failed That's a good question, but it could be solved separately, for all I care
          Hide
          cos Konstantin Boudnik added a comment - - edited

          BTW, the service still isn't getting stopped on apt-get purge ignite-hadoop*. Perhaps, there's more to it?

          Show
          cos Konstantin Boudnik added a comment - - edited BTW, the service still isn't getting stopped on apt-get purge ignite-hadoop* . Perhaps, there's more to it?
          Hide
          oflebbe Olaf Flebbe added a comment -

          Will investigate, there is clearly something terrible wrong.

          Show
          oflebbe Olaf Flebbe added a comment - Will investigate, there is clearly something terrible wrong.
          Hide
          oflebbe Olaf Flebbe added a comment -

          At least on debian the service is stopping.

          Show
          oflebbe Olaf Flebbe added a comment - At least on debian the service is stopping.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Konstantin Boudnik May I ask if you tried it on bare metal or in docker ?

          If you are trying it in docker, there is obviously much more to do.... and IMHO way out of scope for bigtop.

          Show
          oflebbe Olaf Flebbe added a comment - Konstantin Boudnik May I ask if you tried it on bare metal or in docker ? If you are trying it in docker, there is obviously much more to do.... and IMHO way out of scope for bigtop.
          Hide
          cos Konstantin Boudnik added a comment -

          Sorry for not stating it upfront: yes, I was using our slave:trunk-ubuntu-14.04 image for that. Now you've mentioned it: it totally make sense of course. Sorry for the confusion.

          Now, the one with 'docs' vs 'dirs' is likely to be non-docker specific, right?

          Show
          cos Konstantin Boudnik added a comment - Sorry for not stating it upfront: yes, I was using our slave:trunk-ubuntu-14.04 image for that. Now you've mentioned it: it totally make sense of course. Sorry for the confusion. Now, the one with 'docs' vs 'dirs' is likely to be non-docker specific, right?
          Hide
          cos Konstantin Boudnik added a comment -

          Oh, and perhaps it would make sense to rename the JIRA because clearly it isn't about 'stopping' of the service anymore

          Show
          cos Konstantin Boudnik added a comment - Oh, and perhaps it would make sense to rename the JIRA because clearly it isn't about 'stopping' of the service anymore
          Hide
          oflebbe Olaf Flebbe added a comment -

          Let us fix the docs issue in a different JIRA, and finish this one, since we have a wagonload of other things on our pipeline, most of the more important.

          I would propose "cleaning up the ignite-service".

          And last but not least a +1 to the last patch, of course. Please commit.

          Show
          oflebbe Olaf Flebbe added a comment - Let us fix the docs issue in a different JIRA, and finish this one, since we have a wagonload of other things on our pipeline, most of the more important. I would propose "cleaning up the ignite-service". And last but not least a +1 to the last patch, of course. Please commit.
          Hide
          cos Konstantin Boudnik added a comment -

          Ok, I will change the name in the commit message and open another sub-task, in the parent of this one, to address the docs. Thanks a bunch of fixing all this stuff!

          Show
          cos Konstantin Boudnik added a comment - Ok, I will change the name in the commit message and open another sub-task, in the parent of this one, to address the docs. Thanks a bunch of fixing all this stuff!
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed to the master. Thanks Olaf!

          Show
          cos Konstantin Boudnik added a comment - Pushed to the master. Thanks Olaf!

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development