Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2084

rename all puppet modules to have an underscore rather a dash

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: deployment
    • Labels:
      None

      Description

      It is handy to have a puppet module to be instantiated as a class too.

      Some modules are called "hadoop-foo" which is invalid as a class name.

      Lets rename all modules to "hadoop_foo" to have a valid puppet class name signature. A couple of patches waiting from me does depend on it since the module get's its parameters from hiera.

      1. BIGTOP-2084.1.patch
        166 kB
        Olaf Flebbe
      2. BIGTOP-2084.2.patch
        167 kB
        Olaf Flebbe

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Evans Ye: We talked about this before. Is it possible for you to review this?

          Show
          oflebbe Olaf Flebbe added a comment - - edited Evans Ye : We talked about this before. Is it possible for you to review this?
          Hide
          cos Konstantin Boudnik added a comment -

          Great improvement! Thanks for working on it!

          Show
          cos Konstantin Boudnik added a comment - Great improvement! Thanks for working on it!
          Hide
          evans_ye Evans Ye added a comment - - edited

          Yes this is exactly want we discussed in conference. Thanks for the patch.
          I ran the deployment test on Docker and some issues happened during puppet apply:

          Error: Could not find resource 'Class[Hadoop-hbase::Master]' for relationship from 'Class[Hadoop::Init_hdfs]' on node bigtop1.docker
          

          There're some class name in dependency settings not being updated:

          $ grep -R --color Hadoop-hbase *
          modules/hue/manifests/init.pp:        Class['Hadoop-hbase::Client'] -> Class['Hue::Server']
          modules/hadoop_hbase/manifests/init.pp:      Class['Hadoop::Init_hdfs'] -> Class['Hadoop-hbase::Master']
          

          And oozie as well:

          Error: Could not find resource 'Class[Hadoop-oozie::Server]' for relationship from 'Class[Hadoop::Init_hdfs]' on node bigtop1.docker
          

          After the correction of class name it should be good to go!

          Show
          evans_ye Evans Ye added a comment - - edited Yes this is exactly want we discussed in conference. Thanks for the patch. I ran the deployment test on Docker and some issues happened during puppet apply: Error: Could not find resource ' Class [Hadoop-hbase::Master]' for relationship from ' Class [Hadoop::Init_hdfs]' on node bigtop1.docker There're some class name in dependency settings not being updated: $ grep -R --color Hadoop-hbase * modules/hue/manifests/init.pp: Class ['Hadoop-hbase::Client'] -> Class ['Hue::Server'] modules/hadoop_hbase/manifests/init.pp: Class ['Hadoop::Init_hdfs'] -> Class ['Hadoop-hbase::Master'] And oozie as well: Error: Could not find resource ' Class [Hadoop-oozie::Server]' for relationship from ' Class [Hadoop::Init_hdfs]' on node bigtop1.docker After the correction of class name it should be good to go!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Thanks Evans Ye for running the CI test. I have all kind of problems right now to get it run.

          And for sure: I missed the issues you discovered. Uploading a new patch in a few minutes.

          Show
          oflebbe Olaf Flebbe added a comment - Thanks Evans Ye for running the CI test. I have all kind of problems right now to get it run. And for sure: I missed the issues you discovered. Uploading a new patch in a few minutes.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Renamed the Class Resources, too.

          Show
          oflebbe Olaf Flebbe added a comment - Renamed the Class Resources, too.
          Hide
          oflebbe Olaf Flebbe added a comment -

          The toolchain still works, and I do not think we actually need to switch. Should we ask INFRA wether this is actually needed?

          Show
          oflebbe Olaf Flebbe added a comment - The toolchain still works, and I do not think we actually need to switch. Should we ask INFRA wether this is actually needed?
          Hide
          cos Konstantin Boudnik added a comment -

          I think this comment belongs to a different JIRA, no?

          Show
          cos Konstantin Boudnik added a comment - I think this comment belongs to a different JIRA, no?
          Hide
          oflebbe Olaf Flebbe added a comment -

          Yep, that's the second time Apple Safari mixed two different issues. Weird.

          Show
          oflebbe Olaf Flebbe added a comment - Yep, that's the second time Apple Safari mixed two different issues. Weird.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Will commit ...

          Show
          oflebbe Olaf Flebbe added a comment - Will commit ...

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development