Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2028

Enhance puppet config of zookeeper to support kerberized clients

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: deployment
    • Labels:
      None
    1. BIGTOP-2028.2.patch
      9 kB
      Olaf Flebbe
    2. BIGTOP-2028.1.patch
      21 kB
      Olaf Flebbe

      Issue Links

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        committed. Thanks Evans Ye!

        Show
        oflebbe Olaf Flebbe added a comment - committed. Thanks Evans Ye !
        Hide
        evans_ye Evans Ye added a comment -

        LGTM, +1 w/o testing.

        Show
        evans_ye Evans Ye added a comment - LGTM, +1 w/o testing.
        Hide
        oflebbe Olaf Flebbe added a comment - - edited

        merging with bigtop's new role concept BIGTOP-1746 was easy.

        I rebased the patch to be dependent on BIGTOP-2084

        Show
        oflebbe Olaf Flebbe added a comment - - edited merging with bigtop's new role concept BIGTOP-1746 was easy. I rebased the patch to be dependent on BIGTOP-2084
        Hide
        evans_ye Evans Ye added a comment -

        Just for a notice that BIGTOP-1746 is committed.

        Show
        evans_ye Evans Ye added a comment - Just for a notice that BIGTOP-1746 is committed.
        Hide
        evans_ye Evans Ye added a comment -

        OK, Thanks. That's what I planned to do at the very beginning. So sorry my bad writing skill confuses you.

        Show
        evans_ye Evans Ye added a comment - OK, Thanks. That's what I planned to do at the very beginning. So sorry my bad writing skill confuses you.
        Hide
        oflebbe Olaf Flebbe added a comment -

        Do BIGTOP-1746 first. I will rebase BIGTOP-2028 .

        Show
        oflebbe Olaf Flebbe added a comment - Do BIGTOP-1746 first. I will rebase BIGTOP-2028 .
        Hide
        evans_ye Evans Ye added a comment -

        Sorry I didn't get it. Can you elaborate what alternative you're proposing which we can finally get both BIGTOP-2028 and BIGTOP-1746 in with least effort?

        Show
        evans_ye Evans Ye added a comment - Sorry I didn't get it. Can you elaborate what alternative you're proposing which we can finally get both BIGTOP-2028 and BIGTOP-1746 in with least effort?
        Hide
        oflebbe Olaf Flebbe added a comment -

        I think it would be easier for me the other way:

        • I would have to adjust to BIGTOP-1746 anyway. We already have a different role concept.
        • I would have to adapt it to the current "concept" and than change it again.
        • I have a ton of other kerberos related changes to offload, which would stall 1746 further ...

        I still have to read through all the comments of BIGTOP-1746 and I do not like to stall this effort.

        Show
        oflebbe Olaf Flebbe added a comment - I think it would be easier for me the other way: I would have to adjust to BIGTOP-1746 anyway. We already have a different role concept. I would have to adapt it to the current "concept" and than change it again. I have a ton of other kerberos related changes to offload, which would stall 1746 further ... I still have to read through all the comments of BIGTOP-1746 and I do not like to stall this effort.
        Hide
        evans_ye Evans Ye added a comment -

        Hi Olaf Flebbe I found that BIGTOP-1746 and this definitely will conflict. So, my thought is to get that fairly larger one in and then you can rebase on the new role based code structure for zookeeper module. At the high level point of view this might be a better choice which leads lesser effort. Do you agree?

        Show
        evans_ye Evans Ye added a comment - Hi Olaf Flebbe I found that BIGTOP-1746 and this definitely will conflict. So, my thought is to get that fairly larger one in and then you can rebase on the new role based code structure for zookeeper module. At the high level point of view this might be a better choice which leads lesser effort. Do you agree?
        Hide
        evans_ye Evans Ye added a comment -

        I did a test, but found that there's still some unchanged name(hadoop-zookeeper) in hieradata/bigtop/cluster.yaml and manifest/cluster.pp which fails the deployment.

        Show
        evans_ye Evans Ye added a comment - I did a test, but found that there's still some unchanged name(hadoop-zookeeper) in hieradata/bigtop/cluster.yaml and manifest/cluster.pp which fails the deployment.
        Hide
        cos Konstantin Boudnik added a comment -

        Yeah, that'd be great! Thanks for fixing this stuff, BTW!

        Show
        cos Konstantin Boudnik added a comment - Yeah, that'd be great! Thanks for fixing this stuff, BTW!
        Hide
        oflebbe Olaf Flebbe added a comment -

        Thats because hadoop-whatever is an invalid class name because of the dash. Should I propose to change all the classnames to valid ones in a different JIRA. Than this and the following JIRAs are more easy to read?

        Show
        oflebbe Olaf Flebbe added a comment - Thats because hadoop-whatever is an invalid class name because of the dash. Should I propose to change all the classnames to valid ones in a different JIRA. Than this and the following JIRAs are more easy to read?
        Hide
        evans_ye Evans Ye added a comment -

        This is a great stuff we're eager to have. Just one quick question why you change the directory name, class name, etc from hadoop-zookeeper to hadoop_zookeeper? It's not that easy to read the patch since we see the entirely delete/add operations instead of changes in line.

        Show
        evans_ye Evans Ye added a comment - This is a great stuff we're eager to have. Just one quick question why you change the directory name, class name, etc from hadoop-zookeeper to hadoop_zookeeper? It's not that easy to read the patch since we see the entirely delete/add operations instead of changes in line.

          People

          • Assignee:
            oflebbe Olaf Flebbe
            Reporter:
            oflebbe Olaf Flebbe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development