Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      Automate creation of bigtop/slaves docker images.

      1. BIGTOP-1996.1.patch
        8 kB
        Olaf Flebbe
      2. BIGTOP-1996.2.patch
        14 kB
        Olaf Flebbe
      3. BIGTOP-1996.3.patch
        14 kB
        Olaf Flebbe
      4. BIGTOP-1996.4.patch
        17 kB
        Olaf Flebbe
      5. BIGTOP-1996.5.patch
        17 kB
        Olaf Flebbe
      6. BIGTOP-1996.6.patch
        17 kB
        Olaf Flebbe
      7. BIGTOP-1996.7.patch
        17 kB
        Olaf Flebbe

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          Thanks to open up the jira. Just want to let you know how I built the images now.
          Currently I'm using Jenkins job to create slaves images and push them up to the docker hub manually: http://bigtop01.cloudera.org:8080/view/Docker/job/Docker-Toolchain-Trunk/
          It'd be better to wrap them as Dockerfiles and puts under bigtop/docker/bigtop-slaves directory.

          Show
          evans_ye Evans Ye added a comment - Thanks to open up the jira. Just want to let you know how I built the images now. Currently I'm using Jenkins job to create slaves images and push them up to the docker hub manually: http://bigtop01.cloudera.org:8080/view/Docker/job/Docker-Toolchain-Trunk/ It'd be better to wrap them as Dockerfiles and puts under bigtop/docker/bigtop-slaves directory.
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Yep Evans Ye thanks for pointing me to the missing piece!

          Regarding the naming as of BIGTOP-1953: Yep, should be better to include "trunk" for git trunk and the branch name for branches. Will include in my WIP

          Show
          oflebbe Olaf Flebbe added a comment - - edited Yep Evans Ye thanks for pointing me to the missing piece! Regarding the naming as of BIGTOP-1953 : Yep, should be better to include "trunk" for git trunk and the branch name for branches. Will include in my WIP
          Hide
          oflebbe Olaf Flebbe added a comment -

          Uploaded WIP patch.

          You may be curious why I include puppet_modules in this patch.

          I need to integrate openjdk8 in BIGTOP-1936, located in debian-backports. I am using apt::backports to add into sources

          Show
          oflebbe Olaf Flebbe added a comment - Uploaded WIP patch. You may be curious why I include puppet_modules in this patch. I need to integrate openjdk8 in BIGTOP-1936 , located in debian-backports. I am using apt::backports to add into sources
          Hide
          oflebbe Olaf Flebbe added a comment -

          Please review

          Show
          oflebbe Olaf Flebbe added a comment - Please review
          Hide
          oflebbe Olaf Flebbe added a comment -

          Added a last minute change to support adding PPA to ubuntu

          Show
          oflebbe Olaf Flebbe added a comment - Added a last minute change to support adding PPA to ubuntu
          Hide
          oflebbe Olaf Flebbe added a comment -

          Support for fedora-20 as well.
          "official" Docker image is broken, need to enable fedora-updates-testing, since one gets conflicts for openssl and kerberos.

          Show
          oflebbe Olaf Flebbe added a comment - Support for fedora-20 as well. "official" Docker image is broken, need to enable fedora-updates-testing, since one gets conflicts for openssl and kerberos.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Evans Ye : Sorry for the constant stream of updates. This should be final.

          Show
          oflebbe Olaf Flebbe added a comment - Evans Ye : Sorry for the constant stream of updates. This should be final.
          Hide
          evans_ye Evans Ye added a comment -

          Looks good. One small concern. Is it better to combine all 3 RUN commands into one striped command? In that way we reduce the layers of docker images.

          Show
          evans_ye Evans Ye added a comment - Looks good. One small concern. Is it better to combine all 3 RUN commands into one striped command? In that way we reduce the layers of docker images.
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Removing on of the docker aufs layers, two for fedora.

          I have no idea how I can merge all RUN commands to one, since the target directory of the COPY has to be created first and the second RUN is dependent of the COPY.

          Show
          oflebbe Olaf Flebbe added a comment - - edited Removing on of the docker aufs layers, two for fedora. I have no idea how I can merge all RUN commands to one, since the target directory of the COPY has to be created first and the second RUN is dependent of the COPY.
          Hide
          evans_ye Evans Ye added a comment -

          You can do that since docker will put the directory/file in the right place anyway:

          FROM centos:6
          MAINTAINER oflebbe@apache.org
          
          COPY bigtop_toolchain /etc/puppet/modules/bigtop_toolchain
          RUN rpm -ivh http://yum.puppetlabs.com/puppetlabs-release-el-6.noarch.rpm; \
              yum -y install curl sudo unzip wget puppet tar; \
              puppet apply -e "include bigtop_toolchain::puppet-modules" ; \
              puppet apply -e "include bigtop_toolchain::installer"
          

          However, it's a minor change so I'll let you decide.
          Here's my +1 for the last patch, its good!

          Show
          evans_ye Evans Ye added a comment - You can do that since docker will put the directory/file in the right place anyway: FROM centos:6 MAINTAINER oflebbe@apache.org COPY bigtop_toolchain /etc/puppet/modules/bigtop_toolchain RUN rpm -ivh http: //yum.puppetlabs.com/puppetlabs-release-el-6.noarch.rpm; \ yum -y install curl sudo unzip wget puppet tar; \ puppet apply -e "include bigtop_toolchain::puppet-modules" ; \ puppet apply -e "include bigtop_toolchain::installer" However, it's a minor change so I'll let you decide. Here's my +1 for the last patch, its good!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Indeed, wil change the files again.

          Show
          oflebbe Olaf Flebbe added a comment - Indeed, wil change the files again.
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Patch edited, uploaded and tested. Ok, to commit ?

          Show
          oflebbe Olaf Flebbe added a comment - - edited Patch edited, uploaded and tested. Ok, to commit ?
          Hide
          oflebbe Olaf Flebbe added a comment -

          Eeek, opensuse had a cut&paste error, fixed

          Show
          oflebbe Olaf Flebbe added a comment - Eeek, opensuse had a cut&paste error, fixed
          Hide
          evans_ye Evans Ye added a comment -

          +1. I've committed this. Thanks for following up with my comment Olaf Flebbe.

          Show
          evans_ye Evans Ye added a comment - +1. I've committed this. Thanks for following up with my comment Olaf Flebbe .

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development