Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: toolchain
    • Labels:
      None

      Description

      This issue aims at providing an JDK8 to bigtop_toolchain.

      Is a prerequiste for some components, for instance presto

      1. BIGTOP-1936.4.patch
        2 kB
        Olaf Flebbe
      2. BIGTOP-1936.3.patch
        2 kB
        Olaf Flebbe
      3. BIGTOP-1936.2.patch
        2 kB
        Olaf Flebbe
      4. BIGTOP-1936.1.patch
        1.0 kB
        Olaf Flebbe

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Thanks for reviewing

          Show
          oflebbe Olaf Flebbe added a comment - Thanks for reviewing
          Hide
          cos Konstantin Boudnik added a comment -

          +1 looks fine (didn't do the testing though).

          And the default seems to remain on JDK7 for now, which is expected. Thanks!

          Show
          cos Konstantin Boudnik added a comment - +1 looks fine (didn't do the testing though). And the default seems to remain on JDK7 for now, which is expected. Thanks!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Argh ... fixed opensuse

          Show
          oflebbe Olaf Flebbe added a comment - Argh ... fixed opensuse
          Hide
          oflebbe Olaf Flebbe added a comment -

          Tested and now includes all supported architectures.

          Show
          oflebbe Olaf Flebbe added a comment - Tested and now includes all supported architectures.
          Hide
          cos Konstantin Boudnik added a comment -

          Everyone is welcome to help with it, BTW

          Show
          cos Konstantin Boudnik added a comment - Everyone is welcome to help with it, BTW
          Hide
          jonathak Jonathan Kelly added a comment -

          What's the status of the testing? Thanks!

          Show
          jonathak Jonathan Kelly added a comment - What's the status of the testing? Thanks!
          Hide
          oflebbe Olaf Flebbe added a comment -

          Should be final. Doing additional testing ...

          Show
          oflebbe Olaf Flebbe added a comment - Should be final. Doing additional testing ...
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          Add a work in progress patch for debian-8...

          puppet apt module is needed, to manipulate backports. In BIGTOP-1996 puppet-modules from toolchain will be installed

          Show
          oflebbe Olaf Flebbe added a comment - - edited Add a work in progress patch for debian-8... puppet apt module is needed, to manipulate backports. In BIGTOP-1996 puppet-modules from toolchain will be installed
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          We need support in the slaves for it, since the backports repository must be enabled for debian

          Show
          oflebbe Olaf Flebbe added a comment - - edited We need support in the slaves for it, since the backports repository must be enabled for debian
          Hide
          cos Konstantin Boudnik added a comment -

          Where's the PR for this? I don't see any links in this JIRA. Could someone add the weblink to the github's PR to the "Issue Links" section? Thanks!

          Show
          cos Konstantin Boudnik added a comment - Where's the PR for this? I don't see any links in this JIRA. Could someone add the weblink to the github's PR to the "Issue Links" section? Thanks!
          Hide
          warwithin YoungWoo Kim added a comment -

          Olaf Flebbe, Tom Zeng, Jonathan Kelly

          I've just updated BIGTOP-1561

          At this point, JAVA_HOME on bigtop_toolchain should point out Java version 7 and as Olaf described, installed OpenJDK8 and env variable JAVA8_HOME are required as well due to the requirement Java8u40+ for building Presto.

          From the PR, I removed hard-coded JAVA_HOME. now, scripts and wrappers just validate version number from 'java -version'. that being said, 'java' command from the PATH will be used for running Presto. I believe that way is convenient for users.

          Show
          warwithin YoungWoo Kim added a comment - Olaf Flebbe , Tom Zeng , Jonathan Kelly I've just updated BIGTOP-1561 At this point, JAVA_HOME on bigtop_toolchain should point out Java version 7 and as Olaf described, installed OpenJDK8 and env variable JAVA8_HOME are required as well due to the requirement Java8u40+ for building Presto. From the PR, I removed hard-coded JAVA_HOME. now, scripts and wrappers just validate version number from 'java -version'. that being said, 'java' command from the PATH will be used for running Presto. I believe that way is convenient for users.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Correct me if i am wrong. The presto patch uses JAVA8_HOME=/usr/lib/jvm/java-1.8.0. But the bigtop_toolchain part for setting this directory up is missing.

          This JIRA was meant to provide /usr/lib/jvm/java-1.8.0 via puppet.

          Show
          oflebbe Olaf Flebbe added a comment - Correct me if i am wrong. The presto patch uses JAVA8_HOME=/usr/lib/jvm/java-1.8.0. But the bigtop_toolchain part for setting this directory up is missing. This JIRA was meant to provide /usr/lib/jvm/java-1.8.0 via puppet.
          Hide
          evans_ye Evans Ye added a comment -

          Agree. Most of the time we update our packaging code with things like introducing new components/daemons, add new configuration files, major refractory such as sqoop, etc. I don't think upgrading java version changes our packaging code. I suggest to add tickets when something really happened.

          Show
          evans_ye Evans Ye added a comment - Agree. Most of the time we update our packaging code with things like introducing new components/daemons, add new configuration files, major refractory such as sqoop, etc. I don't think upgrading java version changes our packaging code. I suggest to add tickets when something really happened.
          Hide
          cos Konstantin Boudnik added a comment -

          Unless there are changes in the build process/options we should be fine, I think.

          Show
          cos Konstantin Boudnik added a comment - Unless there are changes in the build process/options we should be fine, I think.
          Hide
          jonathak Jonathan Kelly added a comment -

          But there could still be changes necessary on the Bigtop packaging side, right? Maybe not though.

          Show
          jonathak Jonathan Kelly added a comment - But there could still be changes necessary on the Bigtop packaging side, right? Maybe not though.
          Hide
          cos Konstantin Boudnik added a comment -

          What do you mean by

          different JIRA tickets for Java 8 support for Hadoop, HBase, and etc

          The components should support JDK8 at the code level and start officially building the releases with it.

          Show
          cos Konstantin Boudnik added a comment - What do you mean by different JIRA tickets for Java 8 support for Hadoop, HBase, and etc The components should support JDK8 at the code level and start officially building the releases with it.
          Hide
          jonathak Jonathan Kelly added a comment -

          That probably would be best. They could be added as sub-tasks of this one.

          Show
          jonathak Jonathan Kelly added a comment - That probably would be best. They could be added as sub-tasks of this one.
          Hide
          tomzeng Tom Zeng added a comment -

          Ok I see. I think once the Presto install script is set up to pick up openjdk-8, it should make it easier for components to pick up Java 8 as well. Do we need different JIRA tickets for Java 8 support for Hadoop, HBase, and etc?

          Show
          tomzeng Tom Zeng added a comment - Ok I see. I think once the Presto install script is set up to pick up openjdk-8, it should make it easier for components to pick up Java 8 as well. Do we need different JIRA tickets for Java 8 support for Hadoop, HBase, and etc?
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          This JIRA was only meant as to provide a openjdk-8 . it does not enable it . It just siitting there for project to pick it up – for instance presto.

          Show
          oflebbe Olaf Flebbe added a comment - - edited This JIRA was only meant as to provide a openjdk-8 . it does not enable it . It just siitting there for project to pick it up – for instance presto.
          Hide
          cos Konstantin Boudnik added a comment -

          Let's make sure that base components - Hadoop, HBase - are switching to JDK8 as well.

          Show
          cos Konstantin Boudnik added a comment - Let's make sure that base components - Hadoop, HBase - are switching to JDK8 as well.
          Hide
          oflebbe Olaf Flebbe added a comment -
          • openjdk-8 is available for jessie from backports
          • Seems to be available for current centos/rhel 7 and 6 from the main repository.
          • Seems to be available as package java-1_8_0-openjdk-devel for openSuSE 13.2
          Show
          oflebbe Olaf Flebbe added a comment - openjdk-8 is available for jessie from backports Seems to be available for current centos/rhel 7 and 6 from the main repository. There is only a ppa https://launchpad.net/~openjdk-r/+archive/ubuntu/ppa containing openjdk-8 for ubuntu. But contains FX as well... Seems to be available as package java-1_8_0-openjdk-devel for openSuSE 13.2

            People

            • Assignee:
              oflebbe Olaf Flebbe
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              5 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development