Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      Bump up Phoenix version to 4.3.1.

      Notable changes for Phoenix 4.3.1:

      The Apache Phoenix team is pleased to announce the immediate
      availability of the 4.3.1 release. Highlights of the release being:

      • Global client side resource metrics
      • SQL command to turn Phoenix tracing ON/OFF
      • SQL command to allow setting tracing sampling frequency
      • Capability to pass guide post config params through UPDATE STATISTIC call
      • Over 20 bug fixes

      Release notes for Phoenix 4.3.0:

      The Apache Phoenix team is pleased to announce the immediate
      availability of the 4.3 release. Highlights include:

      • functional indexes [1]
      • map-reduce over Phoenix tables [2]
      • cross join support [3]
      • query hint to force index usage [4]
      • set HBase properties through ALTER TABLE
      • ISO-8601 date format support on input
      • RAND built-in for random number generation
      • ANSI SQL date/time literals
      • query timeout support in JDBC Statement
      • over 90 bug fixes

      The release is available through maven or may be downloaded here [5].

      Regards,
      The Apache Phoenix Team

      [1] http://phoenix.apache.org/secondary_indexing.html#Functional_Indexes
      [2] http://phoenix.apache.org/phoenix_mr.html
      [3] http://phoenix.apache.org/joins.html
      [4] http://phoenix.apache.org/secondary_indexing.html#Examples
      [5] http://phoenix.apache.org/download.html

      1. BIGTOP-1741.1.patch
        3 kB
        YoungWoo Kim
      2. BIGTOP-1741.2.patch
        2 kB
        YoungWoo Kim
      3. BIGTOP-1741.3.patch
        3 kB
        YoungWoo Kim
      4. BIGTOP-1741.4.patch
        14 kB
        YoungWoo Kim
      5. BIGTOP-1741.5.patch
        15 kB
        Olaf Flebbe
      6. BIGTOP-1741.6.patch
        14 kB
        YoungWoo Kim

        Issue Links

          Activity

          Hide
          warwithin YoungWoo Kim added a comment -

          First patch, BIGTOP-1741.1.patch

          Show
          warwithin YoungWoo Kim added a comment - First patch, BIGTOP-1741.1.patch
          Hide
          warwithin YoungWoo Kim added a comment -

          Updated patch, BIGTOP-1741.2.patch

          Show
          warwithin YoungWoo Kim added a comment - Updated patch, BIGTOP-1741.2.patch
          Hide
          warwithin YoungWoo Kim added a comment -
          Show
          warwithin YoungWoo Kim added a comment - BIGTOP-1741.3.patch
          Hide
          warwithin YoungWoo Kim added a comment -
          Show
          warwithin YoungWoo Kim added a comment - BIGTOP-1741.4.patch
          Hide
          oflebbe Olaf Flebbe added a comment -

          fixed a linitian Warning, added bigtop.bom to Sources

          Show
          oflebbe Olaf Flebbe added a comment - fixed a linitian Warning, added bigtop.bom to Sources
          Hide
          oflebbe Olaf Flebbe added a comment -

          YoungWoo Kim : Please forgive me for uploading an enhanced patch. A +1 from my side, but haven't tested functionality.

          Show
          oflebbe Olaf Flebbe added a comment - YoungWoo Kim : Please forgive me for uploading an enhanced patch. A +1 from my side, but haven't tested functionality.
          Hide
          warwithin YoungWoo Kim added a comment -

          Thanks Olaf Flebbe!

          Andrew Purtell, Would be appreciate if you look into this patch. I've modified the smoke tests for Phoenix like below:

          +  static String phoenixEnd2EndTestCommand = JAVA_HOME + "/bin/java -cp " +
          +    HBASE_HOME + "/conf/*" + ":" + PHOENIX_HOME + "/lib/*" + ":" +
          +    HBASE_HOME + "/lib/*" + " org.apache.phoenix.end2end.End2EndTestDriver";
           
             @Test
          -  public void testSaltedTableVarLengthRowKey() {
          -    runTest("org.apache.phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT")
          +  public void testPhoenixEnd2End() {
          +    sh.exec(phoenixEnd2EndTestCommand);
          +    assertTrue("end2end test failed", sh.getRet() == 0);
          
          

          I just run the 'End2EndTestDriver' directly instead of adding each Integration Test class. I'm curious whether the changes are safe for sanity check.

          Show
          warwithin YoungWoo Kim added a comment - Thanks Olaf Flebbe ! Andrew Purtell , Would be appreciate if you look into this patch. I've modified the smoke tests for Phoenix like below: + static String phoenixEnd2EndTestCommand = JAVA_HOME + "/bin/java -cp " + + HBASE_HOME + "/conf/*" + ":" + PHOENIX_HOME + "/lib/*" + ":" + + HBASE_HOME + "/lib/*" + " org.apache.phoenix.end2end.End2EndTestDriver" ; @Test - public void testSaltedTableVarLengthRowKey() { - runTest( "org.apache.phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT" ) + public void testPhoenixEnd2End() { + sh.exec(phoenixEnd2EndTestCommand); + assertTrue( "end2end test failed" , sh.getRet() == 0); I just run the 'End2EndTestDriver' directly instead of adding each Integration Test class. I'm curious whether the changes are safe for sanity check.
          Hide
          cos Konstantin Boudnik added a comment -

          Andrew Purtell, YoungWoo Kim: are we going anywhere with this patch? It seems that I can not even build phoenix-4.2.2 as it can not be compiled on top of the current HBase version. That's what I am getting:

          [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java:[598,9] no suitable method found for assertTrue(org.apache.hadoop.hbase.KeepDeletedCells)
              method org.junit.Assert.assertTrue(java.lang.String,boolean) is not applicable
                (actual and formal argument lists differ in length)
              method org.junit.Assert.assertTrue(boolean) is not applicable
                (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion)
          [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java:[602,9] no suitable method found for assertFalse(org.apache.hadoop.hbase.KeepDeletedCells)
              method org.junit.Assert.assertFalse(java.lang.String,boolean) is not applicable
                (actual and formal argument lists differ in length)
              method org.junit.Assert.assertFalse(boolean) is not applicable
                (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion)
          [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.
          java:[607,9] no suitable method found for assertFalse(org.apache.hadoop.hbase.KeepDeletedCells)
              method org.junit.Assert.assertFalse(java.lang.String,boolean) is not applicable
                (actual and formal argument lists differ in length)
              method org.junit.Assert.assertFalse(boolean) is not applicable
                (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion)
          

          Would be great to be able to do a 1,0RC finally.

          Show
          cos Konstantin Boudnik added a comment - Andrew Purtell , YoungWoo Kim : are we going anywhere with this patch? It seems that I can not even build phoenix-4.2.2 as it can not be compiled on top of the current HBase version. That's what I am getting: [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java:[598,9] no suitable method found for assertTrue(org.apache.hadoop.hbase.KeepDeletedCells) method org.junit.Assert.assertTrue(java.lang.String,boolean) is not applicable (actual and formal argument lists differ in length) method org.junit.Assert.assertTrue(boolean) is not applicable (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion) [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java:[602,9] no suitable method found for assertFalse(org.apache.hadoop.hbase.KeepDeletedCells) method org.junit.Assert.assertFalse(java.lang.String,boolean) is not applicable (actual and formal argument lists differ in length) method org.junit.Assert.assertFalse(boolean) is not applicable (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion) [ERROR] /ws/output/phoenix/phoenix-4.2.2/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT. java:[607,9] no suitable method found for assertFalse(org.apache.hadoop.hbase.KeepDeletedCells) method org.junit.Assert.assertFalse(java.lang.String,boolean) is not applicable (actual and formal argument lists differ in length) method org.junit.Assert.assertFalse(boolean) is not applicable (actual argument org.apache.hadoop.hbase.KeepDeletedCells cannot be converted to boolean by method invocation conversion) Would be great to be able to do a 1,0RC finally.
          Hide
          apurtell Andrew Purtell added a comment -

          It seems that I can not even build phoenix-4.2.2 as it can not be compiled on top of the current HBase version

          The latest Phoenix release is 4.3.1. The latest HBase release is 0.98.12. These are happy together. Can we update the BOM to pull them in both?

          Show
          apurtell Andrew Purtell added a comment - It seems that I can not even build phoenix-4.2.2 as it can not be compiled on top of the current HBase version The latest Phoenix release is 4.3.1. The latest HBase release is 0.98.12. These are happy together. Can we update the BOM to pull them in both?
          Hide
          cos Konstantin Boudnik added a comment -

          By all means: I am all for it. While updating HBase seems like a minor task, this JIRA is a bit work. It'd be great if you can help with the review, once YoungWoo Kim is done with 4.3.1 update. Thanks a lot guys!

          Show
          cos Konstantin Boudnik added a comment - By all means: I am all for it. While updating HBase seems like a minor task, this JIRA is a bit work. It'd be great if you can help with the review, once YoungWoo Kim is done with 4.3.1 update. Thanks a lot guys!
          Hide
          apurtell Andrew Purtell added a comment -

          I could take this and an HBase upgrade issue directly too. Definitely can review. Let me know your preference YoungWoo Kim.

          I just run the 'End2EndTestDriver' directly instead of adding each Integration Test class. I'm curious whether the changes are safe for sanity check.

          Yes that's fine. Pardon my tardiness.

          Show
          apurtell Andrew Purtell added a comment - I could take this and an HBase upgrade issue directly too. Definitely can review. Let me know your preference YoungWoo Kim . I just run the 'End2EndTestDriver' directly instead of adding each Integration Test class. I'm curious whether the changes are safe for sanity check. Yes that's fine. Pardon my tardiness.
          Hide
          cos Konstantin Boudnik added a comment -

          Thank you very much guys!

          Show
          cos Konstantin Boudnik added a comment - Thank you very much guys!
          Hide
          cos Konstantin Boudnik added a comment -

          Bumping to Blocker as 4.2.2 can not be built.

          Show
          cos Konstantin Boudnik added a comment - Bumping to Blocker as 4.2.2 can not be built.
          Hide
          warwithin YoungWoo Kim added a comment -

          Andrew Purtell, Konstantin Boudnik. Thanks for the comment!

          I'll revise the patch for Phoenix 4.3.1.

          Show
          warwithin YoungWoo Kim added a comment - Andrew Purtell , Konstantin Boudnik . Thanks for the comment! I'll revise the patch for Phoenix 4.3.1.
          Hide
          warwithin YoungWoo Kim added a comment -

          BIGTOP-1741.6.patch

          • Upgrade Phoenix to 4.3.1
          Show
          warwithin YoungWoo Kim added a comment - BIGTOP-1741.6.patch Upgrade Phoenix to 4.3.1
          Hide
          cos Konstantin Boudnik added a comment -

          I was able to build Phoenix with this patch in place on Ubuntu 14.04
          It fixes the immediate issue with the broken build and clearly it is good with Hbase 0.98.10.1

          +1
          I will wait until the end of the day and commit this if Andrew Purtell or anyone else don't have any other comments.

          Show
          cos Konstantin Boudnik added a comment - I was able to build Phoenix with this patch in place on Ubuntu 14.04 It fixes the immediate issue with the broken build and clearly it is good with Hbase 0.98.10.1 +1 I will wait until the end of the day and commit this if Andrew Purtell or anyone else don't have any other comments.
          Hide
          apurtell Andrew Purtell added a comment -

          Looks good. Let's commit this.

          I will file a new issue for upgrading to HBase 0.98.12 and if that causes issues we can defer it.

          Show
          apurtell Andrew Purtell added a comment - Looks good. Let's commit this. I will file a new issue for upgrading to HBase 0.98.12 and if that causes issues we can defer it.
          Hide
          cos Konstantin Boudnik added a comment -

          Committed and pushed to the master. Thanks YoungWoo Kim

          Show
          cos Konstantin Boudnik added a comment - Committed and pushed to the master. Thanks YoungWoo Kim

            People

            • Assignee:
              warwithin YoungWoo Kim
              Reporter:
              warwithin YoungWoo Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development