Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1603

Rename docker-puppet and vagrant-puppet to better indicate its function and difference

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: deployment
    • Labels:
      None

      Description

      Since we're close to the official release which brings the docker provisioner up to the surface. It'd be better to have component names reflect its function naively. (Sorry for the bad naming at the very beginning...). This is also a recall of jay vyas's comment in BIGTOP-1578, and I'm with him. The proposed change:

      docker-puppet --> vagrant-puppet-docker 
      vagrant-puppet --> vagrant-puppet-vm
      
      1. BIGTOP-1603.1.patch
        56 kB
        Evans Ye
      2. BIGTOP-1603.2.patch
        56 kB
        Evans Ye

        Activity

        Hide
        evans_ye Evans Ye added a comment -

        If you think the change is reasonable, I'll make a patch and update the readme and corresponding documents.

        Show
        evans_ye Evans Ye added a comment - If you think the change is reasonable, I'll make a patch and update the readme and corresponding documents.
        Hide
        rvs Roman Shaposhnik added a comment -

        Good idea.

        Show
        rvs Roman Shaposhnik added a comment - Good idea.
        Hide
        cos Konstantin Boudnik added a comment -

        vagrant-puppet-vm is already sitting under vm/ folder

        Show
        cos Konstantin Boudnik added a comment - vagrant-puppet-vm is already sitting under vm/ folder
        Hide
        evans_ye Evans Ye added a comment - - edited

        Hi Konstantin Boudnik, well, we now only named it vagrant-puppet instead of vagrant-puppet-vm.
        The idea of this change is to have the flexibility to add more provider under vm/ w/o messing up the folder structure. For example, we can add aws:

        vagrant-puppet-docker 
        vagrant-puppet-vm
        vagrant-puppet-aws
        

        So, do you think it's a good way to go?

        Show
        evans_ye Evans Ye added a comment - - edited Hi Konstantin Boudnik , well, we now only named it vagrant-puppet instead of vagrant-puppet-vm . The idea of this change is to have the flexibility to add more provider under vm/ w/o messing up the folder structure. For example, we can add aws: vagrant-puppet-docker vagrant-puppet-vm vagrant-puppet-aws So, do you think it's a good way to go?
        Hide
        cos Konstantin Boudnik added a comment - - edited

        Ah, I see the point. Let's also update the docs accordingly if needed.

        Show
        cos Konstantin Boudnik added a comment - - edited Ah, I see the point. Let's also update the docs accordingly if needed.
        Hide
        evans_ye Evans Ye added a comment - - edited

        Uploaded a patch to perform bigtop-deploy/vm folder refractory.
        Basically the patch is to move the directories(see description) to new names. Following docs mentioned vagrant-puppet or docker-puppet has been updated as well:

        • README.md
        • bigtop-deploy/puppet/README.md
        • bigtop-deploy/vm/vagrant-puppet-docker/README.md

        For docs on our wiki, google search site:https://cwiki.apache.org/confluence "vagrant-puppet" OR "docker-puppet"
        found:

        I'll update them accordingly once committed.

        Show
        evans_ye Evans Ye added a comment - - edited Uploaded a patch to perform bigtop-deploy/vm folder refractory. Basically the patch is to move the directories(see description) to new names. Following docs mentioned vagrant-puppet or docker-puppet has been updated as well: README.md bigtop-deploy/puppet/README.md bigtop-deploy/vm/vagrant-puppet-docker/README.md For docs on our wiki, google search site: https://cwiki.apache.org/confluence "vagrant-puppet" OR "docker-puppet" found: https://cwiki.apache.org/confluence/display/BIGTOP/Index https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=34018936 I'll update them accordingly once committed.
        Hide
        jayunit100 jay vyas added a comment -

        +1 looks beautiful Evans Ye. Commit when ready !
        I tested it w/ vagrant up and it worked good for me.

        Show
        jayunit100 jay vyas added a comment - +1 looks beautiful Evans Ye . Commit when ready ! I tested it w/ vagrant up and it worked good for me.
        Hide
        evans_ye Evans Ye added a comment -

        Thanks jay vyas.
        Fixed the white space in patch 1 and committed to the master.
        I've updated the wiki as well to reflect the change.

        Show
        evans_ye Evans Ye added a comment - Thanks jay vyas . Fixed the white space in patch 1 and committed to the master. I've updated the wiki as well to reflect the change.

          People

          • Assignee:
            evans_ye Evans Ye
            Reporter:
            evans_ye Evans Ye
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development