Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1472

Hadoop RPM build is broken after BIGTOP-1462

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 1.0.0
    • Component/s: build
    • Labels:
      None

      Description

      BIGTOP-1462 uses PKG_NAME instead of NAME in packages.gradle, but there is no PKG_NAME for Hadoop in bigtop.mk, it caused the Hadoop build failed.

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment -

          Committed and pushed as 4df9e69

          Show
          cos Konstantin Boudnik added a comment - Committed and pushed as 4df9e69
          Hide
          cos Konstantin Boudnik added a comment -

          Actually, this fix has been already committed as 4df9e69 this morning. So, I am going to close this ticket.
          But I think adding HADOOP_PKG_NAME to the BOM won't hurt. So, feel free to open a separate ticket for that and provide a patch. Thanks!

          Show
          cos Konstantin Boudnik added a comment - Actually, this fix has been already committed as 4df9e69 this morning. So, I am going to close this ticket. But I think adding HADOOP_PKG_NAME to the BOM won't hurt. So, feel free to open a separate ticket for that and provide a patch. Thanks!
          Hide
          huLiu Hu Liu, added a comment -

          Thanks for the answer. In my opinion:

          1) all the components in bigtop.mk have the PKG_NAME except the Hadoop, we'd better add it for Hadoop too.
          2) adding the HADOOP_PKG_NAME doesn't affect make build, because it use HADOOP_NAME

          Show
          huLiu Hu Liu, added a comment - Thanks for the answer. In my opinion: 1) all the components in bigtop.mk have the PKG_NAME except the Hadoop, we'd better add it for Hadoop too. 2) adding the HADOOP_PKG_NAME doesn't affect make build, because it use HADOOP_NAME
          Hide
          cos Konstantin Boudnik added a comment -

          because if we add a component where it is missed - we'll face the same trouble. We either:

          • set a reasonable default (like in my patch)
          • or error-out of the variable isn't present.
            Existing make build provides the former semantic. I don't see why we should deviate from it.
          Show
          cos Konstantin Boudnik added a comment - because if we add a component where it is missed - we'll face the same trouble. We either: set a reasonable default (like in my patch) or error-out of the variable isn't present. Existing make build provides the former semantic. I don't see why we should deviate from it.
          Hide
          huLiu Hu Liu, added a comment -

          Hi Konstantin Boudnik,

          Why not just add the HADOOP_PKG_NAME into bigtop.mk? I think it should be more simple.

          Show
          huLiu Hu Liu, added a comment - Hi Konstantin Boudnik , Why not just add the HADOOP_PKG_NAME into bigtop.mk? I think it should be more simple.
          Hide
          plinnell Peter Linnell added a comment -

          +1 LGTM

          Show
          plinnell Peter Linnell added a comment - +1 LGTM
          Hide
          cos Konstantin Boudnik added a comment -

          A fix.

          Show
          cos Konstantin Boudnik added a comment - A fix.

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              huLiu Hu Liu,
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development