Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: build
    • Labels:
      None

      Description

      With the advent of BIGTOP-1201 we can start gradually moving away from make. I am proposing to soft-deprecate the make package build by adding a warning to the make driver to reflect on the fact.

      1. BIGTOP-1314.patch
        3 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          apurtell Andrew Purtell added a comment -

          This does seem like something that could have been discussed ahead of taking any action, only because I'm not sure removing the 'make' based build is consensus. I think it is, but we should check.

          Show
          apurtell Andrew Purtell added a comment - This does seem like something that could have been discussed ahead of taking any action, only because I'm not sure removing the 'make' based build is consensus. I think it is, but we should check.
          Hide
          cos Konstantin Boudnik added a comment -

          Mark, the answer is "it depends". This commit doesn't remove the support - it merely declares that sometimes in the future it might be dropped. When Gradle work was started there's was a discussion or two just along these lines (sorry, don't have a prooflink handy, but we can find it if needed), e.g. let's move away from make as it is overly complex, not JVM friendly, etc.

          If people feel like the make shall stay and be advanced - let's vote by all means. The fact that this JIRA has been reviewed and committed isn't a declaration of abandonment of the make part I see that Jay has started the VOTE thread - perhaps it should be lead by a DISCUSS first?

          Show
          cos Konstantin Boudnik added a comment - Mark, the answer is "it depends". This commit doesn't remove the support - it merely declares that sometimes in the future it might be dropped. When Gradle work was started there's was a discussion or two just along these lines (sorry, don't have a prooflink handy, but we can find it if needed), e.g. let's move away from make as it is overly complex, not JVM friendly, etc. If people feel like the make shall stay and be advanced - let's vote by all means. The fact that this JIRA has been reviewed and committed isn't a declaration of abandonment of the make part I see that Jay has started the VOTE thread - perhaps it should be lead by a DISCUSS first?
          Hide
          mgrover Mark Grover added a comment -

          Guys, I know you both are big advocates of community and I am still learning the rope so please ignore me if you think I am not making sense. But, I think decisions like deprecating the project's existing build system in support of a new system deserve a VOTE thread on the dev mailing list. I think JIRAs are not followed by everyone and arguably not the best place to discuss issues like this that have a widespread impact.

          What do you think?

          Show
          mgrover Mark Grover added a comment - Guys, I know you both are big advocates of community and I am still learning the rope so please ignore me if you think I am not making sense. But, I think decisions like deprecating the project's existing build system in support of a new system deserve a VOTE thread on the dev mailing list. I think JIRAs are not followed by everyone and arguably not the best place to discuss issues like this that have a widespread impact. What do you think?
          Hide
          cos Konstantin Boudnik added a comment -

          Committed to the master.

          Show
          cos Konstantin Boudnik added a comment - Committed to the master.
          Hide
          rvs Roman Shaposhnik added a comment -

          +1

          Show
          rvs Roman Shaposhnik added a comment - +1
          Hide
          cos Konstantin Boudnik added a comment -

          Seems to be doing the job.

          Show
          cos Konstantin Boudnik added a comment - Seems to be doing the job.

            People

            • Assignee:
              cos Konstantin Boudnik
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development