Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1287

Mahout smokes : Remove dirchlet/meanshift clustering

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      We need to remove dirchlet and meanshift clustering (removed in mahout 9.x).

      Also formatting is totally wacky so i fixed formatting while at it as well.

      In BIGTOP-1282, we bumped to 9x, so probably this will necessary to keep our smoke tests working.

      1. BIGTOP-1287.patch
        18 kB
        jay vyas
      2. BIGTOP-1287.patch
        21 kB
        jay vyas

        Issue Links

          Activity

          Hide
          jayunit100 jay vyas added a comment -

          patch ^^ (untested... anyone got a cluster working feel free to give it a try or else i will later )

          Show
          jayunit100 jay vyas added a comment - patch ^^ (untested... anyone got a cluster working feel free to give it a try or else i will later )
          Hide
          cos Konstantin Boudnik added a comment -

          jay vyas, is the patch actual? Could you please to make sure it is still valid and mark the ticket as "Patch Avail" to draw some reviewers attention? Thanks!

          Show
          cos Konstantin Boudnik added a comment - jay vyas , is the patch actual? Could you please to make sure it is still valid and mark the ticket as "Patch Avail" to draw some reviewers attention? Thanks!
          Hide
          jayunit100 jay vyas added a comment -

          sure ! Ready for revioew

          Show
          jayunit100 jay vyas added a comment - sure ! Ready for revioew
          Hide
          cos Konstantin Boudnik added a comment -

          From a quick glance the patch look ok.
          Please remove the whitespace changes though - there's a whole bunch of them

          Show
          cos Konstantin Boudnik added a comment - From a quick glance the patch look ok. Please remove the whitespace changes though - there's a whole bunch of them
          Hide
          cos Konstantin Boudnik added a comment -

          jay vyas, will be there any progress on this? Or we aren't sure about Mahout at all?

          Show
          cos Konstantin Boudnik added a comment - jay vyas , will be there any progress on this? Or we aren't sure about Mahout at all?
          Hide
          jayunit100 jay vyas added a comment - - edited

          yup ready to go ; just need to remove the whitespace changes. i forgot how to do that have to google there is some trick to do it in git..... or just push it in as is... its not like we are really going to maintain it much longer

          Show
          jayunit100 jay vyas added a comment - - edited yup ready to go ; just need to remove the whitespace changes. i forgot how to do that have to google there is some trick to do it in git..... or just push it in as is... its not like we are really going to maintain it much longer
          Hide
          cos Konstantin Boudnik added a comment -

          Still would be nice to get rid of these pestering little whitespaces. It is easy to do with
          git apply --ignore-whitespace

          Show
          cos Konstantin Boudnik added a comment - Still would be nice to get rid of these pestering little whitespaces. It is easy to do with git apply --ignore-whitespace
          Hide
          jayunit100 jay vyas added a comment -

          lemme do this tonite and then shall i commit ?

          Show
          jayunit100 jay vyas added a comment - lemme do this tonite and then shall i commit ?
          Hide
          jayunit100 jay vyas added a comment -

          lemme do this tonite and then shall i commit ?

          Show
          jayunit100 jay vyas added a comment - lemme do this tonite and then shall i commit ?
          Hide
          cos Konstantin Boudnik added a comment -

          yup

          Show
          cos Konstantin Boudnik added a comment - yup
          Hide
          jayunit100 jay vyas added a comment - - edited

          okiedokie heres the new patch ! looks ok? now that im back in massachusets i remember how easy it is to fix whitespace

          Show
          jayunit100 jay vyas added a comment - - edited okiedokie heres the new patch ! looks ok? now that im back in massachusets i remember how easy it is to fix whitespace
          Hide
          cos Konstantin Boudnik added a comment -

          I still see a bunch of things like

          -	/**
          -	 * Individual tests (i.e. movie lens factorizer) will selectively copy this directory into the 
          -	 * distributed file system & then run tests against it (i.e. movie lens factorizer uses "fs -put" after
          -	 * formatting a csv file in the tmp dir).
          -	 */
          +    /**
          +    * Individual tests (i.e. movie lens factorizer) will selectively copy this directory into the
          +    * distributed file system & then run tests against it (i.e. movie lens factorizer uses "fs -put" after
          +    * formatting a csv file in the tmp dir).
          +    */
          

          and so on. Looks like formatting goes wrong. I can fix it for you using IDEA, of you want?

          Show
          cos Konstantin Boudnik added a comment - I still see a bunch of things like - /** - * Individual tests (i.e. movie lens factorizer) will selectively copy this directory into the - * distributed file system & then run tests against it (i.e. movie lens factorizer uses "fs -put" after - * formatting a csv file in the tmp dir). - */ + /** + * Individual tests (i.e. movie lens factorizer) will selectively copy this directory into the + * distributed file system & then run tests against it (i.e. movie lens factorizer uses "fs -put" after + * formatting a csv file in the tmp dir). + */ and so on. Looks like formatting goes wrong. I can fix it for you using IDEA, of you want?
          Hide
          jayunit100 jay vyas added a comment -

          okay ! commited (i assume the "yup" was a preapproved +1).

          Show
          jayunit100 jay vyas added a comment - okay ! commited (i assume the "yup" was a preapproved +1).
          Hide
          jayunit100 jay vyas added a comment -

          hmmmm i just saw this. sorry about this i just pushed. somehow this comment didnt show up

          Show
          jayunit100 jay vyas added a comment - hmmmm i just saw this. sorry about this i just pushed. somehow this comment didnt show up
          Hide
          jayunit100 jay vyas added a comment - - edited

          Konstantin Boudnik...........sorry about that comment. it didnt show in my browser and so i pushed the change in.

          I created BIGTOP-1287 to do a global cleanup of formatting.

          in any case, i think that the formatting, in this file, has actually be cleaned up and fixed in this commit (its just that the formatting was bad before).

          Show
          jayunit100 jay vyas added a comment - - edited Konstantin Boudnik ...........sorry about that comment. it didnt show in my browser and so i pushed the change in. I created BIGTOP-1287 to do a global cleanup of formatting. in any case, i think that the formatting, in this file, has actually be cleaned up and fixed in this commit (its just that the formatting was bad before ).
          Hide
          cos Konstantin Boudnik added a comment -

          No worries. If the change is committed - please close the ticket accordingly. Thanks!

          Show
          cos Konstantin Boudnik added a comment - No worries. If the change is committed - please close the ticket accordingly. Thanks!
          Hide
          jayunit100 jay vyas added a comment -

          Ok resolving

          Show
          jayunit100 jay vyas added a comment - Ok resolving

            People

            • Assignee:
              jayunit100 jay vyas
              Reporter:
              jayunit100 jay vyas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development