Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-5255

Fix over-aggressive division futurization.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • 2.6.0
    • 2.7.0
    • sdk-py-core
    • None

    Description

      When converting from Python 2 to Python 3, `a / b` becomes `a // b` only for ints, but it is incorrect to do this substitution for floating point division. 

       

      I noticed this change in the microbenchmarks, but we should do an audit to make sure we haven't broken things elsewhere. 

      Attachments

        Issue Links

          is a child of

          Improvement - An improvement or enhancement to an existing feature or task. BEAM-1251 Python 3 Support

          • P2 - Default priority. Will be triaged and planned according to community practices.
          • Triage Needed
          links to

          Web Link GitHub Pull Request #6293

          Activity

            People

              tvalentyn Valentyn Tymofieiev
              robertwb Robert Bradshaw
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m