[ARTEMIS-808] AccessControlException when closing a connection with a security manager.

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0
• Component/s: Broker
• Assignee: Justin Bertram
• Reporter: Jeff Mesnil
• Created: 18/Oct/16 16:41
• Updated: 21/Oct/16 18:40
• Resolved: 18/Oct/16 21:49

Description

We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a security manager closes a JMS connection:

org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: java.security.AccessControlException: WFSM000001: Permission check failed (permission "("java.lang.RuntimePermission" "modifyThread")" in code source "(vfs:/content/test.jar <no signer certificates>)" of "ModuleClassLoader for Module "deployment.test.jar:main" from Service Module Loader")
    at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
    at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
    at java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
    at java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
    at org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
    at org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)

I suspect that the change that was made for ARTEMIS-538 must ensure that the executor is shutdown in an priviledged block.

Issue Links

• links to: GitHub Pull Request #847