[ARTEMIS-538] [Artemis Testsuite] JMSFailoverListenerTest#testManualFailover fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.3.0
• Assignee: Unassigned
• Reporter: Erich Duda
• Created: 25/May/16 11:22
• Updated: 03/Nov/16 20:41
• Resolved: 25/May/16 13:56

Description

java.lang.AssertionError: expected:<FAILURE_DETECTED> but was:<FAILOVER_FAILED>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.activemq.artemis.tests.integration.jms.cluster.JMSFailoverListenerTest.testManualFailover(JMSFailoverListenerTest.java:228)

I found out that problem is in [1]. When events occur consecutive, ordering of their executions is not guaranteed.

[1]

ActiveMQConnection.java

private static class FailoverEventListenerImpl implements FailoverEventListener {

      private final WeakReference<ActiveMQConnection> connectionRef;

      FailoverEventListenerImpl(final ActiveMQConnection connection) {
         connectionRef = new WeakReference<ActiveMQConnection>(connection);
      }

      @Override
      public void failoverEvent(final FailoverEventType eventType) {
         ActiveMQConnection conn = connectionRef.get();

         if (conn != null) {
            try {
               final FailoverEventListener failoverListener = conn.getFailoverListener();

               if (failoverListener != null) {

                  new Thread(new Runnable() {
                     public void run() {
                        failoverListener.failoverEvent(eventType);
                     }
                  }).start();
               }
            }
            catch (JMSException e) {
               if (!conn.closed) {
                  ActiveMQJMSClientLogger.LOGGER.errorCallingFailoverListener(e);
               }
            }
         }

      }
   }

Issue Links

• links to: GitHub Pull Request #538