Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-17542

[Python][Dev] Document the process to run numpydoc checks

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Archery, Developer Tools, Python
    • None

    Description

      In ARROW-15006 we are adding additional validation checks which are run during CI but the Python development documentation doesn't contain any instructions for running those checks locally. Adding instructions would likely save everyone time.

      However, we actually have two separate ways to run the numpydoc checks locally:

      • archery lint --numpydoc (runs all checks)
      • archery numpydoc (runs all checks except except four we've disabled by default)

      And these two methods differ from how CI runs numpydoc which only runs the three checks (PR01, PR03, and PR10) we know currently pass.

      My thoughts so far are:

      • Having two similar but different ways of running numpydoc might be confusing
      • Ideally, new work should pass all numpydoc checks, not just those we run in CI. Otherwise we're just making future work for ourselves.
      • Giving developers an easy way to run just the checks we have enabled in CI would be good

       

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              brycemecum Bryce Mecum
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: