[AMQ-5629] MapMessage.getChar does not handle if the backing map contains String or UTF8

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Assignee: Timothy A. Bish
• Reporter: Endre Stølsvik
• Created: 03/Mar/15 12:30
• Updated: 04/Mar/15 00:23
• Resolved: 03/Mar/15 21:52

Description

Compare to AMQ-5628.

Read up on http://docs.oracle.com/javaee/1.4/api/javax/jms/MapMessage.html to see that getChar(key) shall be able to compute for something that was stored as a String.

ActiveMQMapMessage, line ~312:

    public char getChar(String name) throws JMSException {
        initializeReading();
        Object value = map.get(name);
        if (value == null) {
            throw new NullPointerException();
        }
        if (value instanceof Character) {
            return ((Character)value).charValue();
        } else {
            throw new MessageFormatException(" cannot read a short from " + value.getClass().getName());
        }
    }

Notice the absent handling of String or UTF8Buffer.

Notice ALSO the wrong wording in the Exception "cannot read SHORT from.." when we're in the CHAR getter.

Issue Links

• is related to: AMQ-5628 MapMessage.getDouble uses Float when converting from String/UTF8
• is related to: AMQ-5632 MapMessage.getBytes crashes with NPE if no value present