[AMQ-5628] MapMessage.getDouble uses Float when converting from String/UTF8

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.12.0
• Assignee: Timothy A. Bish
• Reporter: Endre Stølsvik
• Created: 03/Mar/15 12:27
• Updated: 03/Mar/15 21:29
• Resolved: 03/Mar/15 21:29

Description

ActiveMqMapMessage, line ~437:

    public double getDouble(String name) throws JMSException {
        initializeReading();
        Object value = map.get(name);
        if (value == null) {
            return 0;
        }
        if (value instanceof Double) {
            return ((Double)value).doubleValue();
        }
        if (value instanceof Float) {
            return ((Float)value).floatValue();
        }
        if (value instanceof UTF8Buffer) {
            return Float.valueOf(value.toString()).floatValue();
        }
        if (value instanceof String) {
            return Float.valueOf(value.toString()).floatValue();
        } else {
            throw new MessageFormatException(" cannot read a double from " + value.getClass().getName());
        }
    }

Notice the ifs on String or UTF8Buffer and the use of Float.valueOf.

I noticed this when Strings representing anything higher than Float.MAX_VALUE ended up as Infinity, and anything below Float.MIN_VALUE ended up as 0.

Issue Links

• is related to: AMQ-5632 MapMessage.getBytes crashes with NPE if no value present
• relates to: AMQ-5629 MapMessage.getChar does not handle if the backing map contains String or UTF8