Uploaded image for project: 'Ambari (Retired)'
  1. Ambari (Retired)
  2. AMBARI-17529

Ambari LogSearch REST Layer should not queue up requests that have already been made

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.4.0
    • 2.5.0
    • ambari-server
    • None

    Description

      The review for the fix for AMBARI-17510 brought up some interesting issues that should be investigated and addressed in a separate patch.

      From [~jonathan.hurley]'s comments on https://reviews.apache.org/r/49474/:

      "Based on what we've seen, the requests to the LOGSEARCH endpoint don't return until the connection times out (which could be never depending on what's configured). This will then cause this Executor to fill it's queue with a backlog of requests.

      Instead, maybe it would be better to:

      • Only enqueue if the request isn't already enqueued
      • Use a bounded executor and rejection policy"

      This work will involve investigating the best approach towards limiting the possibility of duplicate requests being made to the LogSearch REST service, either by making a check prior to adding the request, or by using a bounded executor in the way described above.

      Attachments

        1. AMBARI-17529.patch.2
          18 kB
          Bob Nettleton

        Issue Links

          Activity

            People

              rnettleton Bob Nettleton
              rnettleton Bob Nettleton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Slack

                  Issue deployment