[AMBARI-17529] Ambari LogSearch REST Layer should not queue up requests that have already been made

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.5.0
• Component/s: ambari-server
• Assignee: Bob Nettleton
• Reporter: Bob Nettleton
• Created: 01/Jul/16 16:14
• Updated: 07/Nov/16 22:29
• Resolved: 07/Nov/16 21:47

Description

The review for the fix for AMBARI-17510 brought up some interesting issues that should be investigated and addressed in a separate patch.

From jonathan.hurley's comments on https://reviews.apache.org/r/49474/:

"Based on what we've seen, the requests to the LOGSEARCH endpoint don't return until the connection times out (which could be never depending on what's configured). This will then cause this Executor to fill it's queue with a backlog of requests.

Instead, maybe it would be better to:

• Only enqueue if the request isn't already enqueued
• Use a bounded executor and rejection policy"

This work will involve investigating the best approach towards limiting the possibility of duplicate requests being made to the LogSearch REST service, either by making a check prior to adding the request, or by using a bounded executor in the way described above.

Issue Links

• links to: ReviewBoard