Uploaded image for project: 'Ambari'
  1. Ambari
  2. AMBARI-17529

Ambari LogSearch REST Layer should not queue up requests that have already been made

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.4.0
    • 2.5.0
    • ambari-server
    • None

    Description

      The review for the fix for AMBARI-17510 brought up some interesting issues that should be investigated and addressed in a separate patch.

      From [~jonathan.hurley]'s comments on https://reviews.apache.org/r/49474/:

      "Based on what we've seen, the requests to the LOGSEARCH endpoint don't return until the connection times out (which could be never depending on what's configured). This will then cause this Executor to fill it's queue with a backlog of requests.

      Instead, maybe it would be better to:

      • Only enqueue if the request isn't already enqueued
      • Use a bounded executor and rejection policy"

      This work will involve investigating the best approach towards limiting the possibility of duplicate requests being made to the LogSearch REST service, either by making a check prior to adding the request, or by using a bounded executor in the way described above.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rnettleton Bob Nettleton Assign to me
            rnettleton Bob Nettleton
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment