[ACCUMULO-3223] DefaultLoadBalancer allows a NPE just to catch it

• Type: Sub-task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.5.2, 1.6.1
• Fix Version/s: 1.5.3, 1.6.2, 1.7.0
• Component/s: master
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 10/Oct/14 19:16
• Updated: 10/Oct/14 19:40
• Resolved: 10/Oct/14 19:40

Description

getOnlineTabletsForTable can return null for a couple of different reasons. The try/catch prevents the NPE from filtering up, but it is a confusing situation that can be re-written to be more clear.

DefaultLoadBalancer.java

      Map<KeyExtent,TabletStats> onlineTabletsForTable = onlineTablets.get(table);
      try {
        if (onlineTabletsForTable == null) {
          onlineTabletsForTable = new HashMap<KeyExtent,TabletStats>();
          for (TabletStats stat : getOnlineTabletsForTable(tooMuch.server, table))
            onlineTabletsForTable.put(new KeyExtent(stat.extent), stat);
          onlineTablets.put(table, onlineTabletsForTable);
        }
      } catch (Exception ex) {
        log.error("Unable to select a tablet to move", ex);
        return result;
      }