[ACCUMULO-3219] Review Coverity

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Done
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 10/Oct/14 15:41
• Updated: 20/Dec/14 18:41
• Resolved: 20/Dec/14 18:41

Description

Parent task to fix issues that Coverity, a static analysis tool, thinks it found.

If anyone wants to be added to the project that isn't already, let me know, I think I have admin on it now.

https://scan.coverity.com/projects/736?tab=overview

Sub-Tasks

• Division by zero if encryption cipher isn't a block cipher: Resolved
• Unintential integer overflow in Shell authorization timeout: Resolved
• Durability obtained before tablet null check: Resolved
• DefaultLoadBalancer allows a NPE just to catch it: Resolved
• Dead code in ConfigCommand: Resolved
• Unnecessary null check in Authorizations constructor: Resolved
• Default String encoding issue: Resolved
• fix potential resource leaks: Resolved
• Mismatched arguments provided to Retry constructor in RetryFactory: Resolved