[YETUS-465] findbugs should not -1 if base branch has warnings when the patch fixes them

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: Precommit
• Assignee: Unassigned
• Reporter: Xiao Chen
• Created: 13/Oct/16 20:59
• Updated: 14/Oct/16 23:47
• Resolved: 14/Oct/16 23:37

Description

In HADOOP-13669, the base branch (trunk) has 2 findbugs warnings, and a patch fixes them. But pre-commit returns:

-1	findbugs	0m 26s	hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.

IMO this would be better if it says +1 and (had 2 warnings, fixed).

Issue Links

• is related to: HADOOP-13669 KMS Server should log exceptions before throwing