Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7392

SOLR_JAVA_MEM setting in solr.in.sh ignored

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.1
    • 5.2
    • scripts and tools
    • None

    Description

      In Solr 5.1 the following line was added to bin/solr line 1262:

      SOLR_JAVA_MEM=()

      This overrides any setting previously read from solr.in.sh. Only SOLR_HEAP setting could have effect, but it's not even mentioned in solr.in.sh.

      Attachments

        1. SOLR-7392.patch
          3 kB
          Ramkumar Aiyengar
        2. SOLR-7392.patch
          2 kB
          Ramkumar Aiyengar

        Issue Links

          Activity

            Attached initial patch for fixing the issue.

            I will also look for if any other customizations in solr.in.sh were broken (SOLR_OPTS is suspicious..)

            andyetitmoves Ramkumar Aiyengar added a comment - Attached initial patch for fixing the issue. I will also look for if any other customizations in solr.in.sh were broken (SOLR_OPTS is suspicious..)
            emaijala Ere Maijala added a comment -

            True, looks like SOLR_OPTS has the same issue.

            emaijala Ere Maijala added a comment - True, looks like SOLR_OPTS has the same issue.

            Updated patch to respect SOLR_OPTS as well..

            andyetitmoves Ramkumar Aiyengar added a comment - Updated patch to respect SOLR_OPTS as well..

            Commit 1674565 from andyetitmoves in branch 'dev/trunk'
            [ https://svn.apache.org/r1674565 ]

            SOLR-7392: Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

            jira-bot ASF subversion and git services added a comment - Commit 1674565 from andyetitmoves in branch 'dev/trunk' [ https://svn.apache.org/r1674565 ] SOLR-7392 : Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

            Commit 1674574 from andyetitmoves in branch 'dev/branches/branch_5x'
            [ https://svn.apache.org/r1674574 ]

            SOLR-7392: Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

            jira-bot ASF subversion and git services added a comment - Commit 1674574 from andyetitmoves in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674574 ] SOLR-7392 : Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

            Thanks for reporting, Ere.

            andyetitmoves Ramkumar Aiyengar added a comment - Thanks for reporting, Ere.
            anshum Anshum Gupta added a comment -

            Bulk close for 5.2.0.

            anshum Anshum Gupta added a comment - Bulk close for 5.2.0.

            People

              andyetitmoves Ramkumar Aiyengar
              emaijala Ere Maijala
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: