Solr
  1. Solr
  2. SOLR-7392

SOLR_JAVA_MEM setting in solr.in.sh ignored

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.2
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      In Solr 5.1 the following line was added to bin/solr line 1262:

      SOLR_JAVA_MEM=()

      This overrides any setting previously read from solr.in.sh. Only SOLR_HEAP setting could have effect, but it's not even mentioned in solr.in.sh.

      1. SOLR-7392.patch
        3 kB
        Ramkumar Aiyengar
      2. SOLR-7392.patch
        2 kB
        Ramkumar Aiyengar

        Issue Links

          Activity

          Hide
          Ramkumar Aiyengar added a comment -

          Attached initial patch for fixing the issue.

          I will also look for if any other customizations in solr.in.sh were broken (SOLR_OPTS is suspicious..)

          Show
          Ramkumar Aiyengar added a comment - Attached initial patch for fixing the issue. I will also look for if any other customizations in solr.in.sh were broken (SOLR_OPTS is suspicious..)
          Hide
          Ere Maijala added a comment -

          True, looks like SOLR_OPTS has the same issue.

          Show
          Ere Maijala added a comment - True, looks like SOLR_OPTS has the same issue.
          Hide
          Ramkumar Aiyengar added a comment -

          Updated patch to respect SOLR_OPTS as well..

          Show
          Ramkumar Aiyengar added a comment - Updated patch to respect SOLR_OPTS as well..
          Hide
          ASF subversion and git services added a comment -

          Commit 1674565 from Ramkumar Aiyengar in branch 'dev/trunk'
          [ https://svn.apache.org/r1674565 ]

          SOLR-7392: Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

          Show
          ASF subversion and git services added a comment - Commit 1674565 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1674565 ] SOLR-7392 : Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored
          Hide
          ASF subversion and git services added a comment -

          Commit 1674574 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1674574 ]

          SOLR-7392: Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored

          Show
          ASF subversion and git services added a comment - Commit 1674574 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674574 ] SOLR-7392 : Fix SOLR_JAVA_MEM and SOLR_OPTS customizations in solr.in.sh being ignored
          Hide
          Ramkumar Aiyengar added a comment -

          Thanks for reporting, Ere.

          Show
          Ramkumar Aiyengar added a comment - Thanks for reporting, Ere.
          Hide
          Anshum Gupta added a comment -

          Bulk close for 5.2.0.

          Show
          Anshum Gupta added a comment - Bulk close for 5.2.0.

            People

            • Assignee:
              Ramkumar Aiyengar
              Reporter:
              Ere Maijala
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development