Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
New
Description
these tolerance deltas are being (ab)used in various ways in tests. I did some experimentation and they can almost be removed entirely without too much pain.
LUCENE-7997 fixes all similarities such that score() == explain(). It makes its possible to actually debug numeric errors and we need to do that if we have optimizations such as maxscore that care about score values. So I think we should do the same thing elsewhere in scoring (weight/scorer).
We should at the very least fix tests (such as expression tests) that no longer need these deltas and can now assert exact values.
Attachments
Attachments
Issue Links
- is related to
-
LUCENE-8372 TestStemmerOverrideFilter.testRandomRealisticWhiteSpace() failure
- Open