[LUCENE-8008] reduce/remove usages of CheckHits.EXPLAIN_TOLERANCE_*

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 24/Oct/17 14:41
• Updated: 28/Aug/22 15:20
• Resolved: 29/Nov/17 17:15

Description

these tolerance deltas are being (ab)used in various ways in tests. I did some experimentation and they can almost be removed entirely without too much pain.

LUCENE-7997 fixes all similarities such that score() == explain(). It makes its possible to actually debug numeric errors and we need to do that if we have optimizations such as maxscore that care about score values. So I think we should do the same thing elsewhere in scoring (weight/scorer).

We should at the very least fix tests (such as expression tests) that no longer need these deltas and can now assert exact values.

Issue Links

• is related to: LUCENE-8372 TestStemmerOverrideFilter.testRandomRealisticWhiteSpace() failure