[HIVE-22840] Race condition in formatters of TimestampColumnVector and DateColumnVector

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0-alpha-1
• Component/s: storage-api
• Labels: datetime pull-request-available timestamp
• Assignee: Shubham Chaurasia Assign to me
• Reporter: László Bodor
• Created: 06/Feb/20 13:26
• Updated: 27/Feb/24 22:23
• Resolved: 28/Feb/20 18:39

Description

HIVE-22405 added support for proleptic calendar. It uses java's SimpleDateFormat/Calendar APIs which are not thread-safe and cause race in some scenarios.

As a result of those race conditions, we see some exceptions like

1) java.lang.NumberFormatException: For input string: "" 
OR 
java.lang.NumberFormatException: For input string: ".821582E.821582E44"

OR

2) Caused by: java.lang.ArrayIndexOutOfBoundsException: -5325980
    	at sun.util.calendar.BaseCalendar.getCalendarDateFromFixedDate(BaseCalendar.java:453)
    	at java.util.GregorianCalendar.computeFields(GregorianCalendar.java:2397)

This issue is to address those thread-safety issues/race conditions.

cc [~jcamachorodriguez] László Bodor Owen O'Malley

Issue Links

• Is contained by: HIVE-26751 Bug Fixes and Improvements for 3.2.0 release
• relates to: HIVE-22405 Add ColumnVector support for ProlepticCalendar
• links to: GitHub Pull Request #922