Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-22405

Add ColumnVector support for ProlepticCalendar

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Hive recently moved its processing to the proleptic calendar, which has created some issues for users who have dates before 1580 AD.

      I'd propose extending the column vectors for times & dates to encode which calendar they are using.

      • create DateColumnVector that extends LongColumnVector
      • add a method to change calendars to both DateColumnVector and TimestampColumnVector.
        /**
         * Change the calendar to or from proleptic. If the new and old values of the flag are the
         * same, nothing is done.
         * useProleptic - set the flag for the proleptic calendar
         * updateData - change the data to match the new value of the flag.
         */
        void changeCalendar(useProleptic: boolean, updateData: boolean);
      
        /**
         * Detect whether this data is using the proleptic calendar.
         */
        boolean usingProlepticCalendar();
      

      Attachments

        1. HIVE-22405.04.patch
          21 kB
          László Bodor
        2. HIVE-22405.02.patch
          18 kB
          László Bodor
        3. HIVE-22405.01.patch
          60 kB
          László Bodor

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            abstractdog László Bodor Assign to me
            omalley Owen O'Malley
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment